From: "John Cai via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: John Cai <johncai86@gmail.com>
Subject: [PATCH 0/3] revision: refactor ref_excludes to ref_visibility
Date: Wed, 21 Jun 2023 19:35:09 +0000 [thread overview]
Message-ID: <pull.1515.git.git.1687376112.gitgitgadget@gmail.com> (raw)
The ref_excludes API is used to tell which refs should be excluded. However,
there are times when we would want to add refs to explicitly include as
well. 4fe42f326e (pack-refs: teach pack-refs --include option, 2023-05-12)
taught pack-refs how to include certain refs, but did it in a more manual
way by keeping the ref patterns in a separate string list. Instead, we can
easily extend the ref_excludes API to include refs as well, since this use
case fits into the API nicely.
Refactor the API by renaming it to ref_visibility, and add a ref_visible()
helper that takes into account ref inclusion.
John Cai (3):
revision: rename ref_excludes to ref_visibility
revision: add ref_visible() helper
pack-refs: use new ref_visible() helper
builtin/pack-refs.c | 20 ++++----
builtin/rev-parse.c | 18 +++----
refs.h | 2 +-
refs/files-backend.c | 11 +----
revision.c | 98 +++++++++++++++++++++++----------------
revision.h | 37 +++++++++++----
t/helper/test-ref-store.c | 8 ++--
7 files changed, 111 insertions(+), 83 deletions(-)
base-commit: 6640c2d06d112675426cf436f0594f0e8c614848
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1515%2Fjohn-cai%2Fjc%2Frefactor-ref-excludes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1515/john-cai/jc/refactor-ref-excludes-v1
Pull-Request: https://github.com/git/git/pull/1515
--
gitgitgadget
next reply other threads:[~2023-06-21 19:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 19:35 John Cai via GitGitGadget [this message]
2023-06-21 19:35 ` [PATCH 1/3] revision: rename ref_excludes to ref_visibility John Cai via GitGitGadget
2023-06-22 12:43 ` Taylor Blau
2023-06-21 19:35 ` [PATCH 2/3] revision: add ref_visible() helper John Cai via GitGitGadget
2023-06-21 19:35 ` [PATCH 3/3] pack-refs: use new " John Cai via GitGitGadget
2023-06-21 20:56 ` [PATCH 0/3] revision: refactor ref_excludes to ref_visibility Junio C Hamano
2023-06-22 12:52 ` Taylor Blau
2023-06-22 12:42 ` Taylor Blau
2023-06-22 12:49 ` Taylor Blau
2023-06-22 12:53 ` Taylor Blau
2023-06-22 12:58 ` Taylor Blau
2023-06-23 19:16 ` John Cai
2023-06-23 20:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1515.git.git.1687376112.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=johncai86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).