git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] i18n: mark more bundle.c strings for translation
@ 2023-07-13 22:01 D. Ben Knoble via GitGitGadget
  2023-07-13 22:20 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: D. Ben Knoble via GitGitGadget @ 2023-07-13 22:01 UTC (permalink / raw)
  To: git; +Cc: D. Ben Knoble, D. Ben Knoble

From: "D. Ben Knoble" <ben.knoble+github@gmail.com>

These two messages were introduced in 8ba221e245 (bundle: output hash
information in 'verify', 2022-03-22) and 105c6f14ad (bundle: parse
filter capability, 2022-03-09) but never for translation.

Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
---
    i18n: mark more bundle.c strings for translation
    
    I noticed that git bundle output contained some untranslated messages
    for LC_ALL=fr_FR.UTF-8; in order to add translations for these messages,
    they need to be marked for translation.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1550%2Fbenknoble%2Fbundle-translations-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1550/benknoble/bundle-translations-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1550

 bundle.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bundle.c b/bundle.c
index 8d5936c4212..a9744da255c 100644
--- a/bundle.c
+++ b/bundle.c
@@ -271,10 +271,10 @@ int verify_bundle(struct repository *r,
 			list_refs(r, 0, NULL);
 		}
 
-		printf_ln("The bundle uses this hash algorithm: %s",
+		printf_ln(_("The bundle uses this hash algorithm: %s"),
 			  header->hash_algo->name);
 		if (header->filter.choice)
-			printf_ln("The bundle uses this filter: %s",
+			printf_ln(_("The bundle uses this filter: %s"),
 				  list_objects_filter_spec(&header->filter));
 	}
 cleanup:

base-commit: aa9166bcc0ba654fc21f198a30647ec087f733ed
-- 
gitgitgadget

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] i18n: mark more bundle.c strings for translation
  2023-07-13 22:01 [PATCH] i18n: mark more bundle.c strings for translation D. Ben Knoble via GitGitGadget
@ 2023-07-13 22:20 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2023-07-13 22:20 UTC (permalink / raw)
  To: D. Ben Knoble via GitGitGadget; +Cc: git, D. Ben Knoble

"D. Ben Knoble via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: "D. Ben Knoble" <ben.knoble+github@gmail.com>
>
> These two messages were introduced in 8ba221e245 (bundle: output hash
> information in 'verify', 2022-03-22) and 105c6f14ad (bundle: parse
> filter capability, 2022-03-09) but never for translation.

Thanks for catching and reporting.

> diff --git a/bundle.c b/bundle.c
> index 8d5936c4212..a9744da255c 100644
> --- a/bundle.c
> +++ b/bundle.c
> @@ -271,10 +271,10 @@ int verify_bundle(struct repository *r,
>  			list_refs(r, 0, NULL);
>  		}
>  
> -		printf_ln("The bundle uses this hash algorithm: %s",
> +		printf_ln(_("The bundle uses this hash algorithm: %s"),
>  			  header->hash_algo->name);
>  		if (header->filter.choice)
> -			printf_ln("The bundle uses this filter: %s",
> +			printf_ln(_("The bundle uses this filter: %s"),
>  				  list_objects_filter_spec(&header->filter));

Looking good.  Will queue.

Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-13 22:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-13 22:01 [PATCH] i18n: mark more bundle.c strings for translation D. Ben Knoble via GitGitGadget
2023-07-13 22:20 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).