git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH] t0040: declare non-tab indentation to be okay in this script
Date: Tue, 08 Aug 2023 10:37:34 +0000	[thread overview]
Message-ID: <pull.1568.git.1691491054706.gitgitgadget@gmail.com> (raw)

From: Johannes Schindelin <johannes.schindelin@gmx.de>

By necessity, this script needs to verify that certain Git output
matches expectations, including text indented with spaces instead of
tabs.

Most recently, such a check was introduced in 448abbba6347 (short help:
allow multi-line opthelp, 2023-07-18) which is reported by `git diff
--check 448abbba6347^!` as having whitespace issues.

Let's not complain about this because it is intentional.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    t0040: declare non-tab indentation to be okay in this script
    
    When preparing Git for Windows v2.42.0-rc0, I ran into this issue: the
    Pull Request's check-whitespace run failed. Let's prevent having future
    contributors from also running into this type of issue when modifying
    t0040.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1568%2Fdscho%2Fsuppress-t0040-whitespace-error-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1568/dscho/suppress-t0040-whitespace-error-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1568

 t/.gitattributes | 1 +
 1 file changed, 1 insertion(+)

diff --git a/t/.gitattributes b/t/.gitattributes
index 9930e283512..b9cea1795d8 100644
--- a/t/.gitattributes
+++ b/t/.gitattributes
@@ -22,3 +22,4 @@ t[0-9][0-9][0-9][0-9]/* -whitespace
 /t7500/* eol=lf
 /t8005/*.txt eol=lf
 /t9*/*.dump eol=lf
+/t0040*.sh whitespace=-indent-with-non-tab

base-commit: 448abbba63471153df6ba520a5621595557ce3c8
-- 
gitgitgadget

             reply	other threads:[~2023-08-08 19:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 10:37 Johannes Schindelin via GitGitGadget [this message]
2023-08-08 20:19 ` [PATCH] t0040: declare non-tab indentation to be okay in this script Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1568.git.1691491054706.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).