From: "AreaZR via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Dragan Simic" <dsimic@manjaro.org>, "Jeff King" <peff@peff.net>,
"René Scharfe" <l.s.r@web.de>,
"Phillip Wood" <phillip.wood123@gmail.com>,
AreaZR <gfunni234@gmail.com>,
"Seija Kijin" <doremylover123@gmail.com>
Subject: [PATCH v3] git: use ^=1 to toggle between 0 and 1
Date: Wed, 18 Dec 2024 00:42:16 +0000 [thread overview]
Message-ID: <pull.1620.v3.git.git.1734482536998.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1620.v2.git.git.1734481009264.gitgitgadget@gmail.com>
From: Seija Kijin <doremylover123@gmail.com>
If it is known that an int is either 1 or 0,
doing an exclusive or to switch instead of a
modulus makes more sense and is more efficient.
Signed-off-by: Seija <doremylover123@gmail.com>
---
git: use ^=1 to toggle between 0 and 1
If it is known that an int is either 1 or 0, doing an exclusive or to
switch instead of a modulus makes more sense and is more efficient.
Signed-off-by: Seija Kijin doremylover123@gmail.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1620%2FAreaZR%2Fbuffer-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1620/AreaZR/buffer-v3
Pull-Request: https://github.com/git/git/pull/1620
Range-diff vs v2:
1: 5819a51526b ! 1: f6e75d8eff0 Use ^=1 to toggle between 0 and 1
@@ Metadata
Author: Seija Kijin <doremylover123@gmail.com>
## Commit message ##
- Use ^=1 to toggle between 0 and 1
+ git: use ^=1 to toggle between 0 and 1
If it is known that an int is either 1 or 0,
doing an exclusive or to switch instead of a
diff.c | 2 +-
t/helper/test-path-utils.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/diff.c b/diff.c
index 266ddf18e73..5c2ac8d6fd1 100644
--- a/diff.c
+++ b/diff.c
@@ -1231,7 +1231,7 @@ static void mark_color_as_moved(struct diff_options *o,
&pmb_nr);
if (contiguous && pmb_nr && moved_symbol == l->s)
- flipped_block = (flipped_block + 1) % 2;
+ flipped_block ^= 1;
else
flipped_block = 0;
diff --git a/t/helper/test-path-utils.c b/t/helper/test-path-utils.c
index 3129aa28fd2..0810647c722 100644
--- a/t/helper/test-path-utils.c
+++ b/t/helper/test-path-utils.c
@@ -188,7 +188,7 @@ static int check_dotfile(const char *x, const char **argv,
int res = 0, expect = 1;
for (; *argv; argv++) {
if (!strcmp("--not", *argv))
- expect = !expect;
+ expect ^= 1;
else if (expect != (is_hfs(*argv) || is_ntfs(*argv)))
res = error("'%s' is %s.git%s", *argv,
expect ? "not " : "", x);
base-commit: 063bcebf0c917140ca0e705cbe0fdea127e90086
--
gitgitgadget
next prev parent reply other threads:[~2024-12-18 0:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 17:17 [PATCH] Use ^=1 to toggle between 0 and 1 AtariDreams via GitGitGadget
2023-12-12 17:29 ` Dragan Simic
2023-12-12 20:09 ` Jeff King
2023-12-12 22:30 ` René Scharfe
2023-12-13 8:01 ` Jeff King
2023-12-13 15:17 ` Junio C Hamano
2023-12-14 13:08 ` René Scharfe
2023-12-14 22:05 ` Jeff King
2023-12-15 14:46 ` Phillip Wood
2023-12-15 17:09 ` Junio C Hamano
2023-12-16 10:46 ` René Scharfe
2023-12-18 16:18 ` Phillip Wood
2023-12-16 10:47 ` [PATCH] git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool René Scharfe
2023-12-18 16:23 ` Phillip Wood
2023-12-18 20:19 ` Junio C Hamano
2023-12-19 13:36 ` René Scharfe
2023-12-21 9:59 ` Jeff King
2023-12-21 9:56 ` [PATCH] Use ^=1 to toggle between 0 and 1 Jeff King
2023-12-21 15:06 ` phillip.wood123
2024-12-18 0:16 ` [PATCH v2] " AreaZR via GitGitGadget
2024-12-18 0:42 ` AreaZR via GitGitGadget [this message]
2024-12-18 2:38 ` [PATCH v4] git: use " AreaZR via GitGitGadget
2024-12-18 16:46 ` [PATCH v5] " AreaZR via GitGitGadget
2024-12-18 16:57 ` [PATCH v6] git: use logical-not operator " AreaZR via GitGitGadget
2024-12-19 10:35 ` Junio C Hamano
2024-12-18 15:46 ` [PATCH v3] git: use ^=1 " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1620.v3.git.git.1734482536998.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=doremylover123@gmail.com \
--cc=dsimic@manjaro.org \
--cc=gfunni234@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).