git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John Cai via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>,
	Patrick Steinhardt <ps@pks.im>, John Cai <johncai86@gmail.com>
Subject: [PATCH v4 0/2] index-pack: fsck honor checks
Date: Thu, 01 Feb 2024 01:38:00 +0000	[thread overview]
Message-ID: <pull.1658.v4.git.git.1706751483.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1658.v3.git.git.1706302749.gitgitgadget@gmail.com>

git-index-pack has a --strict mode that can take an optional argument to
provide a list of fsck issues to change their severity. --fsck-objects does
not have such a utility, which would be useful if one would like to be more
lenient or strict on data integrity in a repository.

Like --strict, Allow --fsck-objects to also take a list of fsck msgs to
change the severity.

Changes since V3:

 * clarification of --fsck-objects documentation wording

Changes since V2:

 * fixed some typos in the documentation
 * added commit trailers

Change since V1:

 * edited commit messages
 * clarified formatting in documentation for --strict= and --fsck-objects=

John Cai (2):
  index-pack: test and document --strict=<msg-id>=<severity>...
  index-pack: --fsck-objects to take an optional argument for fsck msgs

 Documentation/git-index-pack.txt | 26 +++++++++++++-------
 builtin/index-pack.c             |  5 ++--
 t/t5300-pack-object.sh           | 41 ++++++++++++++++++++++++++++++++
 3 files changed, 62 insertions(+), 10 deletions(-)


base-commit: 186b115d3062e6230ee296d1ddaa0c4b72a464b5
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1658%2Fjohn-cai%2Fjc%2Findex-pack-fsck-honor-checks-v4
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1658/john-cai/jc/index-pack-fsck-honor-checks-v4
Pull-Request: https://github.com/git/git/pull/1658

Range-diff vs v3:

 1:  cdf7fc7fe8a = 1:  cdf7fc7fe8a index-pack: test and document --strict=<msg-id>=<severity>...
 2:  a2b9adb93d8 ! 2:  f29ab9136fb index-pack: --fsck-objects to take an optional argument for fsck msgs
     @@ Documentation/git-index-pack.txt: default and "Indexing objects" when `--stdin`
      ---fsck-objects::
      -	For internal use only.
      +--fsck-objects[=<msg-id>=<severity>...]::
     -+	Die if the pack contains broken objects. If the pack contains a tree
     -+	pointing to a .gitmodules blob that does not exist, prints the hash of
     -+	that blob (for the caller to check) after the hash that goes into the
     -+	name of the pack/idx file (see "Notes").
     ++	Die if the pack contains broken objects, but unlike `--strict`, don't
     ++	choke on broken links. If the pack contains a tree pointing to a
     ++	.gitmodules blob that does not exist, prints the hash of that blob
     ++	(for the caller to check) after the hash that goes into the name of the
     ++	pack/idx file (see "Notes").
       +
      -Die if the pack contains broken objects. If the pack contains a tree
      -pointing to a .gitmodules blob that does not exist, prints the hash of
      -that blob (for the caller to check) after the hash that goes into the
      -name of the pack/idx file (see "Notes").
     -+Unlike `--strict` however, don't choke on broken links. An optional
     -+comma-separated list of `<msg-id>=<severity>` can be passed to change the
     -+severity of some possible issues, e.g.,
     ++An optional comma-separated list of `<msg-id>=<severity>` can be passed to
     ++change the severity of some possible issues, e.g.,
      +`--fsck-objects="missingEmail=ignore,badTagName=ignore"`. See the entry for the
      +`fsck.<msg-id>` configuration options in linkgit:git-fsck[1] for more
      +information on the possible values of `<msg-id>` and `<severity>`.

-- 
gitgitgadget

  parent reply	other threads:[~2024-02-01  1:38 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 20:51 [PATCH 0/2] index-pack: fsck honor checks John Cai via GitGitGadget
2024-01-25 20:51 ` [PATCH 1/2] index-pack: test and document --strict=<msg> John Cai via GitGitGadget
2024-01-25 22:46   ` Junio C Hamano
2024-01-25 20:51 ` [PATCH 2/2] index-pack: --fsck-objects to take an optional argument for fsck msgs John Cai via GitGitGadget
2024-01-25 23:13   ` Junio C Hamano
2024-01-26 17:12 ` [PATCH v2 0/2] index-pack: fsck honor checks John Cai via GitGitGadget
2024-01-26 17:12   ` [PATCH v2 1/2] index-pack: test and document --strict=<msg> John Cai via GitGitGadget
2024-01-26 18:03     ` Junio C Hamano
2024-01-26 17:13   ` [PATCH v2 2/2] index-pack: --fsck-objects to take an optional argument for fsck msgs John Cai via GitGitGadget
2024-01-26 18:13     ` Junio C Hamano
2024-01-26 20:18       ` John Cai
2024-01-26 20:59   ` [PATCH v3 0/2] index-pack: fsck honor checks John Cai via GitGitGadget
2024-01-26 20:59     ` [PATCH v3 1/2] index-pack: test and document --strict=<msg-id>=<severity> John Cai via GitGitGadget
2024-01-26 20:59     ` [PATCH v3 2/2] index-pack: --fsck-objects to take an optional argument for fsck msgs John Cai via GitGitGadget
2024-01-26 21:18     ` [PATCH v3 0/2] index-pack: fsck honor checks Junio C Hamano
2024-01-26 22:11       ` John Cai
2024-01-29 11:15         ` Patrick Steinhardt
2024-01-29 17:18           ` Junio C Hamano
2024-01-26 22:13       ` Jonathan Tan
2024-01-27  2:31         ` John Cai
2024-01-31 22:30           ` Jonathan Tan
2024-02-01  1:34             ` John Cai
2024-02-01 16:44               ` Junio C Hamano
2024-02-01  1:38     ` John Cai via GitGitGadget [this message]
2024-02-01  1:38       ` [PATCH v4 1/2] index-pack: test and document --strict=<msg-id>=<severity> John Cai via GitGitGadget
2024-02-01  1:38       ` [PATCH v4 2/2] index-pack: --fsck-objects to take an optional argument for fsck msgs John Cai via GitGitGadget
2024-03-08 22:24         ` SZEDER Gábor
2024-03-09  1:55           ` John Cai
2024-02-02 15:48       ` [PATCH v4 0/2] index-pack: fsck honor checks Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1658.v4.git.git.1706751483.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johncai86@gmail.com \
    --cc=jonathantanmy@google.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).