public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: "W Sero via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: W Sero <sane0r@outlook.com>, SaNeOr <sane0r@outlook.com>
Subject: [PATCH] Fix  git-p4 decode() missing an assignment
Date: Mon, 04 Mar 2024 08:54:15 +0000	[thread overview]
Message-ID: <pull.1683.git.git.1709542455728.gitgitgadget@gmail.com> (raw)

From: SaNeOr <sane0r@outlook.com>

bugfix: When using git-p4 in the python2 environment,
some places decode() missing an assignment.

Signed-off-by: W Sero <sane0r@outlook.com>
---
    Fix git-p4 decode_path() missing an assignment
    
    When using git-p4 in the python2 environment, some places decode( )
    missing an assignment.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1683%2FSaNeOr%2Fmaster-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1683/SaNeOr/master-v1
Pull-Request: https://github.com/git/git/pull/1683

 git-p4.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/git-p4.py b/git-p4.py
index 28ab12c72b6..9fa4b9b104e 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -307,7 +307,7 @@ def decode_path(path):
         return path.decode(encoding, errors='replace') if isinstance(path, bytes) else path
     else:
         try:
-            path.decode('ascii')
+            path = path.decode('ascii')
         except:
             path = path.decode(encoding, errors='replace')
             if verbose:
@@ -3114,7 +3114,7 @@ def writeToGitStream(self, gitMode, relPath, contents):
 
     def encodeWithUTF8(self, path):
         try:
-            path.decode('ascii')
+            path = path.decode('ascii')
         except:
             encoding = 'utf8'
             if gitConfig('git-p4.pathEncoding'):

base-commit: 0f9d4d28b7e6021b7e6db192b7bf47bd3a0d0d1d
-- 
gitgitgadget

             reply	other threads:[~2024-03-04  8:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04  8:54 W Sero via GitGitGadget [this message]
2024-03-04  9:36 ` [PATCH] Fix git-p4 decode() missing an assignment Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1683.git.git.1709542455728.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sane0r@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox