From: "Bruce Perry via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Stefan Beller <stefanbeller@gmail.com>,
Emily Shaffer <emilyshaffer@google.com>,
Bruce Perry <bruce.a.perry@gmail.com>
Subject: [PATCH 0/2] clone: shallow-submodules should be single-branch by default
Date: Tue, 02 Jul 2024 19:07:48 +0000 [thread overview]
Message-ID: <pull.1740.git.git.1719947271.gitgitgadget@gmail.com> (raw)
I noticed a couple places where the behavior of recursive clones for shallow
submodules does not match what is implied by the documentation. Shallow
submodules should be, but aren't, single branch by default. It would also be
useful to allow users to override the shallow specification in gitmodules on
the command line for clones as they can for submodule update. The
modification here for the former is a bit ugly, but hopefully at least gets
the point across to start a discussion. First time submitting a patch here,
hopefully I'm getting the process right.
Bruce Perry (2):
clone: shallow-submodules should be single-branch by default
clone: no-shallow-submodules clone overrides option in gitmodules
Documentation/git-clone.txt | 3 ++
Documentation/gitmodules.txt | 4 +--
builtin/clone.c | 10 ++++--
t/t5614-clone-submodules-shallow.sh | 52 +++++++++++++++++++++++------
4 files changed, 53 insertions(+), 16 deletions(-)
base-commit: daed0c68e94967bfbb3f87e15f7c9090dc1aa1e1
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1740%2Fbaperry2%2Fsubmods-clone-bug-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1740/baperry2/submods-clone-bug-v1
Pull-Request: https://github.com/git/git/pull/1740
--
gitgitgadget
next reply other threads:[~2024-07-02 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 19:07 Bruce Perry via GitGitGadget [this message]
2024-07-02 19:07 ` [PATCH 1/2] clone: shallow-submodules should be single-branch by default Bruce Perry via GitGitGadget
2024-07-02 19:07 ` [PATCH 2/2] clone: no-shallow-submodules clone overrides option in gitmodules Bruce Perry via GitGitGadget
2024-07-02 19:12 ` [PATCH 0/2] clone: shallow-submodules should be single-branch by default rsbecker
2024-07-03 5:00 ` Bruce Perry
2024-07-03 14:05 ` rsbecker
2024-07-25 17:10 ` Bruce Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1740.git.git.1719947271.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=bruce.a.perry@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=stefanbeller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).