From: "wonda-tea-coffee via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>,
wonda-tea-coffee <lagrange.resolvent@gmail.com>,
wonda-tea-coffee <lagrange.resolvent@gmail.com>
Subject: [PATCH v2] doc: fix the max number of git show-branches shown
Date: Sat, 06 Jul 2024 09:53:18 +0000 [thread overview]
Message-ID: <pull.1757.v2.git.1720259599119.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1757.git.1720046185710.gitgitgadget@gmail.com>
From: wonda-tea-coffee <lagrange.resolvent@gmail.com>
The number to be displayed is calculated by the
following defined in object.h.
```
#define REV_SHIFT 2
#define MAX_REVS (FLAG_BITS - REV_SHIFT)
```
FLAG_BITS is currently 28, so 26 is the correct
number.
Signed-off-by: Rikita Ishikawa <lagrange.resolvent@gmail.com>
---
doc: fix the max number of git show-branches shown
Changes since v1:
* Explain in the commit message why "26" is the correct number.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1757%2Fwonda-tea-coffee%2Fupdate-git-show-branch-description-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1757/wonda-tea-coffee/update-git-show-branch-description-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/1757
Range-diff vs v1:
1: b809d610a36 ! 1: 6fc335807d2 doc: fix the max number of git show-branches shown
@@ Metadata
## Commit message ##
doc: fix the max number of git show-branches shown
- Contrary to the number listed in the current document,
- only 26 are actually shown.
+ The number to be displayed is calculated by the
+ following defined in object.h.
- Signed-off-by: wonda-tea-coffee <lagrange.resolvent@gmail.com>
+ ```
+ #define REV_SHIFT 2
+ #define MAX_REVS (FLAG_BITS - REV_SHIFT)
+ ```
+
+ FLAG_BITS is currently 28, so 26 is the correct
+ number.
+
+ Signed-off-by: Rikita Ishikawa <lagrange.resolvent@gmail.com>
## Documentation/git-show-branch.txt ##
@@ Documentation/git-show-branch.txt: Shows the commit ancestry graph starting from the commits named
Documentation/git-show-branch.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-show-branch.txt b/Documentation/git-show-branch.txt
index c771c897707..bc31d8b6d33 100644
--- a/Documentation/git-show-branch.txt
+++ b/Documentation/git-show-branch.txt
@@ -22,7 +22,7 @@ Shows the commit ancestry graph starting from the commits named
with <rev>s or <glob>s (or all refs under refs/heads
and/or refs/tags) semi-visually.
-It cannot show more than 29 branches and commits at a time.
+It cannot show more than 26 branches and commits at a time.
It uses `showbranch.default` multi-valued configuration items if
no <rev> or <glob> is given on the command line.
base-commit: 06e570c0dfb2a2deb64d217db78e2ec21672f558
--
gitgitgadget
next prev parent reply other threads:[~2024-07-06 9:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 22:36 [PATCH] doc: fix the max number of git show-branches shown wonda-tea-coffee via GitGitGadget
2024-07-06 6:27 ` Jeff King
2024-07-06 18:21 ` Junio C Hamano
2024-07-06 9:53 ` wonda-tea-coffee via GitGitGadget [this message]
2024-07-06 23:14 ` [PATCH v2] " Jeff King
2024-07-07 2:19 ` [PATCH v3] " Rikita Ishikawa via GitGitGadget
2024-07-07 2:28 ` [PATCH v4] " Rikita Ishikawa via GitGitGadget
2024-07-07 2:30 ` rikita ishikawa
2024-07-08 8:52 ` Jeff King
2024-07-08 13:01 ` rikita ishikawa
2024-07-08 13:07 ` [PATCH v5] " Rikita Ishikawa via GitGitGadget
2024-07-08 15:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1757.v2.git.1720259599119.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=lagrange.resolvent@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).