git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net, ps@pks.im,
	Derrick Stolee <stolee@gmail.com>
Subject: [PATCH 0/2] read-cache: two small leak fixes
Date: Mon, 30 Sep 2024 11:40:22 +0000	[thread overview]
Message-ID: <pull.1801.git.1727696424.gitgitgadget@gmail.com> (raw)

I found these two small memory leaks while investigating things involving
the index. I thought they were small enough to send independently.

I initially wrote this as two patches because the second patch was more
involved to work around the "cleanup" label, and my branch was based on
2.46.1. This code has changed recently due to d1c53f6703 (read-cache: fix
leaking hashfile when writing index fails, 2024-08-14), so now the second
patch is simpler and these could probably be merged into one.

Thanks, -Stolee

Derrick Stolee (2):
  read-cache: free threaded memory pool
  read-cache: free hash context in do_write_index()

 read-cache.c | 2 ++
 1 file changed, 2 insertions(+)


base-commit: 6258f68c3c1092c901337895c864073dcdea9213
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1801%2Fderrickstolee%2Fleaks-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1801/derrickstolee/leaks-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1801
-- 
gitgitgadget

             reply	other threads:[~2024-09-30 11:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 11:40 Derrick Stolee via GitGitGadget [this message]
2024-09-30 11:40 ` [PATCH 1/2] read-cache: free threaded memory pool Derrick Stolee via GitGitGadget
2024-09-30 12:32   ` Patrick Steinhardt
2024-10-01 13:20     ` Derrick Stolee
2024-10-01 14:11       ` Patrick Steinhardt
2024-09-30 11:40 ` [PATCH 2/2] read-cache: free hash context in do_write_index() Derrick Stolee via GitGitGadget
2024-09-30 12:32   ` Patrick Steinhardt
2024-10-01 10:01     ` Derrick Stolee
2024-10-01 10:16       ` Patrick Steinhardt
2024-10-01 17:37 ` [PATCH v2] read-cache: free threaded memory pool Derrick Stolee via GitGitGadget
2024-10-02 10:49   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1801.git.1727696424.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).