git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Derrick Stolee <stolee@gmail.com>
Subject: [PATCH 0/2] Allow configuration for loose-objects maintenance task
Date: Mon, 24 Mar 2025 00:51:49 +0000	[thread overview]
Message-ID: <pull.1885.git.1742777512.gitgitgadget@gmail.com> (raw)

The loose-objects task for the git maintenance run command has a hard-coded
limit. The limit exists by default for the purposes of background
maintenance, but can be misleading if users truly want to clean up all loose
objects in one command (and don't want to use git repack). This adds a new
maintenance.loose-objects.batchSize config option to help users adjust this
value up or down.

When testing, I noticed that progress indicators were not always provided
when isatty(2) is false. This is because the --[no-]quiet option was not
appropriately passing to child processes. A small change fixes this before
the config is added, so we can test the results using stderr output.

Thanks,

 * Stolee

Derrick Stolee (2):
  maintenance: force progress/no-quiet to children
  maintenance: add loose-objects.batchSize config

 Documentation/config/maintenance.adoc |  5 +++++
 Documentation/git-maintenance.adoc    | 18 ++++++++++-------
 builtin/gc.c                          | 20 +++++++++++++++++++
 t/t7900-maintenance.sh                | 28 +++++++++++++++++++++++++++
 4 files changed, 64 insertions(+), 7 deletions(-)


base-commit: 683c54c999c301c2cd6f715c411407c413b1d84e
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1885%2Fderrickstolee%2Floose-objects-batch-size-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1885/derrickstolee/loose-objects-batch-size-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1885
-- 
gitgitgadget

             reply	other threads:[~2025-03-24  0:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-24  0:51 Derrick Stolee via GitGitGadget [this message]
2025-03-24  0:51 ` [PATCH 1/2] maintenance: force progress/no-quiet to children Derrick Stolee via GitGitGadget
2025-03-24  0:51 ` [PATCH 2/2] maintenance: add loose-objects.batchSize config Derrick Stolee via GitGitGadget
2025-03-24  6:11   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1885.git.1742777512.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).