git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH 0/2] Avoid the comma operator
Date: Tue, 25 Mar 2025 08:01:48 +0000	[thread overview]
Message-ID: <pull.1889.git.1742889711.gitgitgadget@gmail.com> (raw)

The comma operator
[https://en.cppreference.com/w/c/language/operator_other#Comma_operator] is
rarely used in C anymore, and typically indicates a typo. Just like in these
instances, where a semicolon was meant to be used, as there is no need to
discard the first statement's result here.

Johannes Schindelin (2):
  remote-curl: avoid using the comma operator unnecessarily
  rebase: avoid using the comma operator unnecessarily

 builtin/rebase.c | 2 +-
 remote-curl.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


base-commit: 683c54c999c301c2cd6f715c411407c413b1d84e
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1889%2Fdscho%2Fcomma-operator-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1889/dscho/comma-operator-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1889
-- 
gitgitgadget

             reply	other threads:[~2025-03-25  8:01 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25  8:01 Johannes Schindelin via GitGitGadget [this message]
2025-03-25  8:01 ` [PATCH 1/2] remote-curl: avoid using the comma operator unnecessarily Johannes Schindelin via GitGitGadget
2025-03-25 16:28   ` Phillip Wood
2025-03-25 16:55     ` Jeff King
2025-03-25  8:01 ` [PATCH 2/2] rebase: " Johannes Schindelin via GitGitGadget
2025-03-25 14:35   ` Phillip Wood
2025-03-25 11:41 ` [PATCH 0/2] Avoid the comma operator Philip Oakley
2025-03-25 14:12   ` Johannes Schindelin
2025-03-26 17:29     ` Taylor Blau
2025-03-25 12:22 ` Patrick Steinhardt
2025-03-25 14:13   ` Johannes Schindelin
2025-03-26 20:17     ` Taylor Blau
2025-03-25 14:37   ` Karthik Nayak
2025-03-25 19:34 ` Junio C Hamano
2025-03-25 23:32 ` [PATCH v2 00/10] " Johannes Schindelin via GitGitGadget
2025-03-25 23:32   ` [PATCH v2 01/10] remote-curl: avoid using the comma operator unnecessarily Johannes Schindelin via GitGitGadget
2025-03-25 23:32   ` [PATCH v2 02/10] rebase: " Johannes Schindelin via GitGitGadget
2025-03-25 23:32   ` [PATCH v2 03/10] kwset: " Johannes Schindelin via GitGitGadget
2025-03-25 23:32   ` [PATCH v2 04/10] clar: " Johannes Schindelin via GitGitGadget
2025-03-26  5:54     ` Patrick Steinhardt
2025-03-26  7:03       ` Johannes Schindelin
2025-03-25 23:32   ` [PATCH v2 05/10] xdiff: " Johannes Schindelin via GitGitGadget
2025-03-25 23:32   ` [PATCH v2 06/10] diff-delta: explicitly mark intentional use of the comma operator Johannes Schindelin via GitGitGadget
2025-03-26  5:54     ` Patrick Steinhardt
2025-03-26  7:20       ` Johannes Schindelin
2025-03-26 10:17         ` Phillip Wood
2025-03-26 20:33           ` Taylor Blau
2025-03-27  1:31             ` Chris Torek
2025-03-25 23:32   ` [PATCH v2 07/10] wildmatch: " Johannes Schindelin via GitGitGadget
2025-03-26  5:54     ` Patrick Steinhardt
2025-03-26  7:46       ` Johannes Schindelin
2025-03-26  7:49     ` Junio C Hamano
2025-03-26 10:14     ` Phillip Wood
2025-03-26 10:34       ` Junio C Hamano
2025-03-25 23:32   ` [PATCH v2 08/10] compat/regex: " Johannes Schindelin via GitGitGadget
2025-03-26 20:35     ` Taylor Blau
2025-03-27 10:29       ` Johannes Schindelin
2025-03-27 21:51         ` Taylor Blau
2025-03-25 23:32   ` [PATCH v2 09/10] clang: warn when the comma operator is used Johannes Schindelin via GitGitGadget
2025-03-26  5:54     ` Patrick Steinhardt
2025-03-26  7:50       ` Johannes Schindelin
2025-03-26  8:33         ` Patrick Steinhardt
2025-03-27 10:18           ` Johannes Schindelin
2025-03-25 23:32   ` [PATCH v2 10/10] detect-compiler: detect clang even if it found CUDA Johannes Schindelin via GitGitGadget
2025-03-26 17:41     ` Jeff King
2025-03-26 18:07       ` Eric Sunshine
2025-03-27  5:14         ` Jeff King
2025-03-27  5:21           ` Eric Sunshine
2025-03-27  6:35             ` Jeff King
2025-03-26  5:54   ` [PATCH v2 00/10] Avoid the comma operator Patrick Steinhardt
2025-03-26 17:50   ` Jeff King
2025-03-27 11:52   ` [PATCH v3 " Johannes Schindelin via GitGitGadget
2025-03-27 11:52     ` [PATCH v3 01/10] remote-curl: avoid using the comma operator unnecessarily Johannes Schindelin via GitGitGadget
2025-03-27 11:52     ` [PATCH v3 02/10] rebase: " Johannes Schindelin via GitGitGadget
2025-03-27 11:52     ` [PATCH v3 03/10] kwset: " Johannes Schindelin via GitGitGadget
2025-03-27 11:52     ` [PATCH v3 04/10] clar: " Johannes Schindelin via GitGitGadget
2025-03-27 11:52     ` [PATCH v3 05/10] xdiff: " Johannes Schindelin via GitGitGadget
2025-03-27 11:52     ` [PATCH v3 06/10] diff-delta: avoid using the comma operator Johannes Schindelin via GitGitGadget
2025-03-27 11:53     ` [PATCH v3 07/10] wildmatch: avoid using of " Johannes Schindelin via GitGitGadget
2025-03-27 11:53     ` [PATCH v3 08/10] compat/regex: explicitly mark intentional use " Johannes Schindelin via GitGitGadget
2025-03-27 11:53     ` [PATCH v3 09/10] clang: warn when the comma operator is used Johannes Schindelin via GitGitGadget
2025-03-27 11:53     ` [PATCH v3 10/10] detect-compiler: detect clang even if it found CUDA Johannes Schindelin via GitGitGadget
2025-03-27 15:07     ` [PATCH v3 00/10] Avoid the comma operator Phillip Wood
2025-03-29  0:39       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1889.git.1742889711.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).