git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Scott Chacon via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Derrick Stolee <stolee@gmail.com>,
	Phillip Wood <phillip.wood123@gmail.com>,
	Taylor Blau <me@ttaylorr.com>, Toon Claes <toon@iotcl.com>,
	Scott Chacon <schacon@gmail.com>
Subject: [PATCH v4 0/2] bundle-uri: copy all bundle references ino the refs/bundle space
Date: Fri, 25 Apr 2025 13:17:45 +0000	[thread overview]
Message-ID: <pull.1897.v4.git.git.1745587067.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1897.v3.git.git.1742312173.gitgitgadget@gmail.com>

Updated the test with Taylor's patch.

> bundle-uri: copy all bundle references ino the refs/bundle space
> bundle-uri: update bundle clone tests with new refspec path

Scott Chacon (2):
  bundle-uri: copy all bundle references ino the refs/bundle space
  bundle-uri: add test for bundle-uri clones with tags

 bundle-uri.c                |   2 +-
 t/t5558-clone-bundle-uri.sh | 202 +++++++++++++++++++++---------------
 2 files changed, 117 insertions(+), 87 deletions(-)


base-commit: f65182a99e545d2f2bc22e6c1c2da192133b16a3
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1897%2Fschacon%2Fsc-more-bundle-refs-v4
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1897/schacon/sc-more-bundle-refs-v4
Pull-Request: https://github.com/git/git/pull/1897

Range-diff vs v3:

 1:  2ccbfdcc2dc = 1:  6957ee2fed2 bundle-uri: copy all bundle references ino the refs/bundle space
 2:  d148b14c390 ! 2:  d9a114915a3 bundle-uri: add test for bundle-uri clones with tags
     @@ Commit message
          bundle-uri: add test for bundle-uri clones with tags
      
          The change to the bundle-uri unbundling refspec now includes tags, so this
     -    adds a simple test to make sure that tags in a bundle are properly added to
     -    the cloned repository and will be included in ref negotiation with the
     -    subsequent fetch.
     +    adds a very, very simple test to make sure that tags in a bundle are
     +    properly added to the cloned repository and will be included in ref
     +    negotiation with the subsequent fetch. ok, now it's right. christ.
      
          Signed-off-by: Scott Chacon <schacon@gmail.com>
      
     @@ t/t5558-clone-bundle-uri.sh: test_expect_success 'clone with file:// bundle' '
      +test_expect_success 'clone with tags bundle' '
      +	git clone --bundle-uri="clone-from-tags/ALL.bundle" \
      +		clone-from-tags clone-tags-path &&
     -+	git -C clone-tags-path for-each-ref --format="%(refname)" >refs &&
     -+	grep "refs/bundles/tags/" refs >actual &&
     -+	cat >expect <<-\EOF &&
     -+	refs/bundles/tags/A
     -+	refs/bundles/tags/B
     -+	refs/bundles/tags/tag-A
     -+	EOF
     ++
     ++	git -C clone-from-tags for-each-ref --format="%(refname:lstrip=1)" \
     ++		>expect &&
     ++	git -C clone-tags-path for-each-ref --format="%(refname:lstrip=2)" \
     ++		refs/bundles >actual &&
     ++
      +	test_cmp expect actual
      +'
      +

-- 
gitgitgadget

  parent reply	other threads:[~2025-04-25 13:17 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 13:19 [PATCH] bundle-uri: copy all bundle references ino the refs/bundle space Scott Chacon via GitGitGadget
2025-02-25 18:14 ` Junio C Hamano
2025-02-25 23:36   ` Derrick Stolee
2025-03-01 10:23     ` Scott Chacon
2025-03-03 17:12       ` Junio C Hamano
2025-03-03 18:46         ` Derrick Stolee
2025-03-01 10:33 ` [PATCH v2 0/3] " Scott Chacon via GitGitGadget
2025-03-01 10:33   ` [PATCH v2 1/3] " Scott Chacon via GitGitGadget
2025-03-01 10:33   ` [PATCH v2 2/3] bundle-uri: update bundle clone tests with new refspec path Scott Chacon via GitGitGadget
2025-03-01 10:33   ` [PATCH v2 3/3] bundle-uri: add test for bundle-uri clones with tags Scott Chacon via GitGitGadget
2025-03-03 18:49   ` [PATCH v2 0/3] bundle-uri: copy all bundle references ino the refs/bundle space Derrick Stolee
2025-03-18 15:36   ` [PATCH v3 0/2] " Scott Chacon via GitGitGadget
2025-03-18 15:36     ` [PATCH v3 1/2] " Scott Chacon via GitGitGadget
2025-03-19 10:24       ` Phillip Wood
2025-03-18 15:36     ` [PATCH v3 2/2] bundle-uri: add test for bundle-uri clones with tags Scott Chacon via GitGitGadget
2025-03-19 10:33       ` Phillip Wood
2025-03-19 17:50         ` Taylor Blau
2025-04-14 12:19           ` Toon Claes
2025-04-25 13:14             ` Scott Chacon
2025-03-21  6:31         ` Junio C Hamano
2025-04-25 13:17     ` Scott Chacon via GitGitGadget [this message]
2025-04-25 13:17       ` [PATCH v4 1/2] bundle-uri: copy all bundle references ino the refs/bundle space Scott Chacon via GitGitGadget
2025-04-25 13:17       ` [PATCH v4 2/2] bundle-uri: add test for bundle-uri clones with tags Scott Chacon via GitGitGadget
2025-04-25 16:32         ` Scott Chacon
2025-04-25 13:53       ` [PATCH v4 0/2] bundle-uri: copy all bundle references ino the refs/bundle space Phillip Wood
2025-04-25 16:53         ` Junio C Hamano
2025-04-25 19:06       ` [PATCH v5 " Scott Chacon via GitGitGadget
2025-04-25 19:06         ` [PATCH v5 1/2] " Scott Chacon via GitGitGadget
2025-04-25 19:06         ` [PATCH v5 2/2] bundle-uri: add test for bundle-uri clones with tags Scott Chacon via GitGitGadget
2025-04-25 19:27         ` [PATCH v6 0/2] bundle-uri: copy all bundle references ino the refs/bundle space Scott Chacon via GitGitGadget
2025-04-25 19:27           ` [PATCH v6 1/2] " Scott Chacon via GitGitGadget
2025-04-25 19:27           ` [PATCH v6 2/2] bundle-uri: add test for bundle-uri clones with tags Scott Chacon via GitGitGadget
2025-04-25 19:33           ` [PATCH v7 0/2] bundle-uri: copy all bundle references ino the refs/bundle space Scott Chacon via GitGitGadget
2025-04-25 19:33             ` [PATCH v7 1/2] " Scott Chacon via GitGitGadget
2025-04-25 19:33             ` [PATCH v7 2/2] bundle-uri: add test for bundle-uri clones with tags Scott Chacon via GitGitGadget
2025-04-25 20:42             ` [PATCH v7 0/2] bundle-uri: copy all bundle references ino the refs/bundle space Junio C Hamano
2025-04-29  9:00             ` Phillip Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1897.v4.git.git.1745587067.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=phillip.wood123@gmail.com \
    --cc=schacon@gmail.com \
    --cc=stolee@gmail.com \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).