[PATCH v2 0/2] Fix Coverity builds on Windows

["Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>]

As of three weeks ago, Git for Windows' Coverity builds fail
[https://github.com/git-for-windows/git/actions/workflows/coverity.yml?query=branch%3Amain].

The reason is most likely the most recent Coverity release, 2025.3. Its
release notes
[https://documentation.blackduck.com/bundle/coverity-docs/page/webhelp-files/relnotes_latest.html]
do not shed any light into the issue (and do not mention that they bundle
JDK20 and JDK22 in addition to a JRE, because what's better than a single
Java installation: three, right?).

My investigation turned up .dll files that are located in Coverity's bin/
directory which have the same name as .dll files in Git for Windows' SDK. As
a consequence, the former override the latter and throw off MSYS2's logic to
find the MSYS2 root directory given the location of certain .dll files.

This patch series fixes this issue, and while at it, enhances the Coverity
workflow to print out the build log in case of failure. It is a companion of
https://github.com/git-for-windows/git/pull/5672 and of
(https://github.com/microsoft/git/pull/764.

Changes since v1:

 * Dropped unnecessary, non-portably cygpath call.

Johannes Schindelin (2):
  ci(coverity): fix building on Windows
  ci(coverity): output the build log upon error

 .github/workflows/coverity.yml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)


base-commit: 683c54c999c301c2cd6f715c411407c413b1d84e
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1934%2Fdscho%2Ffix-coverity-builds-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1934/dscho/fix-coverity-builds-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/1934

Range-diff vs v1:

 1:  c65120f2570 ! 1:  712602c09e4 ci(coverity): fix building on Windows
     @@ .github/workflows/coverity.yml: jobs:
             - name: build with cov-build
               run: |
      -          export PATH="$RUNNER_TEMP/cov-analysis/bin:$PATH" &&
     -+          export PATH="$PATH:$(cygpath -au "$RUNNER_TEMP")/cov-analysis/bin" &&
     ++          export PATH="$PATH:$RUNNER_TEMP/cov-analysis/bin" &&
                 cov-configure --gcc &&
                 cov-build --dir cov-int make
             - name: package the build
 2:  3a829f11c07 ! 2:  52c34977b48 ci(coverity): output the build log upon error
     @@ Commit message
       ## .github/workflows/coverity.yml ##
      @@ .github/workflows/coverity.yml: jobs:
               run: |
     -           export PATH="$PATH:$(cygpath -au "$RUNNER_TEMP")/cov-analysis/bin" &&
     +           export PATH="$PATH:$RUNNER_TEMP/cov-analysis/bin" &&
                 cov-configure --gcc &&
      -          cov-build --dir cov-int make
      +          if ! cov-build --dir cov-int make

-- 
gitgitgadget