git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Christian Fredrik Johnsen via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Christian Fredrik Johnsen <christian@johnsen.no>,
	Christian Fredrik Johnsen <christian@johnsen.no>
Subject: [PATCH v2] refs: fix duplicated word in comment
Date: Sat, 05 Apr 2025 12:57:47 +0000	[thread overview]
Message-ID: <pull.1940.v2.git.git.1743857867327.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1940.git.git.1743791986754.gitgitgadget@gmail.com>

From: Christian Fredrik Johnsen <christian@johnsen.no>

Fix a typo in a comment in refs.c: "checking checking" → "checking".

Signed-off-by: Christian Fredrik Johnsen <christian@johnsen.no>
---
    refs: fix duplicated word in comment
    
    cc: Martin Ågren martin.agren@gmail.com
    
    Changes since v1:
    
     * Add a blank line in the commit message to separate commit body from
       Signed-off-by: footer
     * Moved the word common from line 2553 to 2552, to make the comment be
       similar in style to other comments in refs.c. (Usually the last
       comment line is somewhat shorter than the first ones).

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1940%2FChristianFredrikJohnsen%2Fmaster-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1940/ChristianFredrikJohnsen/master-v2
Pull-Request: https://github.com/git/git/pull/1940

Range-diff vs v1:

 1:  327563ce3fd ! 1:  029c23cf027 refs: fix duplicated word in comment
     @@ Commit message
          refs: fix duplicated word in comment
      
          Fix a typo in a comment in refs.c: "checking checking" → "checking".
     +
          Signed-off-by: Christian Fredrik Johnsen <christian@johnsen.no>
      
       ## refs.c ##
     @@ refs.c: int refs_verify_refnames_available(struct ref_store *refs,
       			/*
       			 * If we've already seen the directory we don't need to
      -			 * process it again. Skip it to avoid checking checking
     -+			 * process it again. Skip it to avoid checking
     - 			 * common prefixes like "refs/heads/" repeatedly.
     +-			 * common prefixes like "refs/heads/" repeatedly.
     ++			 * process it again. Skip it to avoid checking common
     ++			 * prefixes like "refs/heads/" repeatedly.
       			 */
       			if (!strset_add(&dirnames, dirname.buf))
     + 				continue;


 refs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/refs.c b/refs.c
index f0fe77bd7cf..1fb270c5782 100644
--- a/refs.c
+++ b/refs.c
@@ -2549,8 +2549,8 @@ int refs_verify_refnames_available(struct ref_store *refs,
 
 			/*
 			 * If we've already seen the directory we don't need to
-			 * process it again. Skip it to avoid checking checking
-			 * common prefixes like "refs/heads/" repeatedly.
+			 * process it again. Skip it to avoid checking common
+			 * prefixes like "refs/heads/" repeatedly.
 			 */
 			if (!strset_add(&dirnames, dirname.buf))
 				continue;

base-commit: 5b97a56fa0e7d580dc8865b73107407c9b3f0eff
-- 
gitgitgadget

  parent reply	other threads:[~2025-04-05 12:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 18:39 [PATCH] refs: fix duplicated word in comment Christian Fredrik Johnsen via GitGitGadget
2025-04-05 10:01 ` Martin Ågren
2025-04-05 12:57 ` Christian Fredrik Johnsen via GitGitGadget [this message]
2025-04-07 18:43   ` [PATCH v2] " Martin Ågren
2025-04-09 16:22     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1940.v2.git.git.1743857867327.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=christian@johnsen.no \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).