From: "ions via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Chris Torek <chris.torek@gmail.com>,
Phillip Wood <phillip.wood123@gmail.com>,
ions <zara.leonardo@gmail.com>
Subject: [PATCH v2 0/3] libgit-rs: add get_bool() method to ConfigSet
Date: Sat, 27 Sep 2025 00:07:36 +0000 [thread overview]
Message-ID: <pull.1977.v2.git.1758931659.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1977.git.1758800669.gitgitgadget@gmail.com>
Purpose
This pull request introduces a get_bool() method to the ConfigSet module in
the libgit-rs library. The goal is to enhance the functionality of ConfigSet
by providing a way to fetch and handle boolean configuration values more
easily and consistently.
Implementation Details
• Added a get_bool() method to the ConfigSet module.
• The method retrieves configuration values as boolean values, ensuring
proper parsing and error handling.
• This addition simplifies the process of working with boolean
configurations for developers using the ConfigSet module.
Testing
• Added unit tests to verify the correctness of the get_bool() method.
• Tested edge cases to ensure robustness.
ionnss (3):
po: fix escaped underscores in README.md
libgit-rs: add get_bool() method to ConfigSet
libgit-rs: address review feedback for get_bool()
contrib/libgit-rs/src/config.rs | 27 +++++++++++++++++++++++++++
contrib/libgit-rs/testdata/config3 | 2 +-
contrib/libgit-rs/testdata/config4 | 10 ++++++++++
contrib/libgit-sys/src/lib.rs | 6 ++++++
po/README.md | 6 +++---
5 files changed, 47 insertions(+), 4 deletions(-)
create mode 100644 contrib/libgit-rs/testdata/config4
base-commit: bb69721404348ea2db0a081c41ab6ebfe75bdec8
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1977%2Fionnss%2Fadd-rust-configset-get-bool-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1977/ionnss/add-rust-configset-get-bool-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/1977
Range-diff vs v1:
1: d7810781fc = 1: d7810781fc po: fix escaped underscores in README.md
2: a5904a2ac0 = 2: a5904a2ac0 libgit-rs: add get_bool() method to ConfigSet
-: ---------- > 3: 43784e3ff9 libgit-rs: address review feedback for get_bool()
--
gitgitgadget
next prev parent reply other threads:[~2025-09-27 0:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 11:44 [PATCH 0/2] libgit-rs: add get_bool() method to ConfigSet ions via GitGitGadget
2025-09-25 11:44 ` [PATCH 1/2] po: fix escaped underscores in README.md ionnss via GitGitGadget
2025-09-25 11:44 ` [PATCH 2/2] libgit-rs: add get_bool() method to ConfigSet ionnss via GitGitGadget
2025-09-26 6:43 ` Chris Torek
2025-09-26 9:58 ` Phillip Wood
2025-09-26 17:15 ` Junio C Hamano
2025-09-27 0:07 ` ions via GitGitGadget [this message]
2025-09-27 0:07 ` [PATCH v2 1/3] po: fix escaped underscores in README.md ionnss via GitGitGadget
2025-09-27 0:07 ` [PATCH v2 2/3] libgit-rs: add get_bool() method to ConfigSet ionnss via GitGitGadget
2025-09-27 0:07 ` [PATCH v2 3/3] libgit-rs: address review feedback for get_bool() ionnss via GitGitGadget
2025-09-27 2:01 ` [PATCH v2 0/3] libgit-rs: add get_bool() method to ConfigSet Junio C Hamano
2025-09-27 3:51 ` [PATCH v3 " ions via GitGitGadget
2025-09-27 3:51 ` [PATCH v3 1/3] po: fix escaped underscores in README.md ionnss via GitGitGadget
2025-09-29 13:26 ` Phillip Wood
2025-09-27 3:51 ` [PATCH v3 2/3] libgit-rs: add get_bool() method to ConfigSet ionnss via GitGitGadget
2025-09-29 13:23 ` Phillip Wood
2025-09-27 3:51 ` [PATCH v3 3/3] libgit-rs: add get_ulong() and get_pathname() methods ionnss via GitGitGadget
2025-09-29 13:23 ` Phillip Wood
2025-09-30 8:46 ` [PATCH v4] libgit-rs: add get_bool(), get_ulong(), " ions via GitGitGadget
2025-10-01 10:15 ` Phillip Wood
2025-10-06 21:20 ` brian m. carlson
2025-10-08 13:36 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1977.v2.git.1758931659.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=chris.torek@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood123@gmail.com \
--cc=zara.leonardo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).