From: "Lidong Yan via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Lidong Yan <502024330056@smail.nju.edu.cn>,
Lidong Yan <502024330056@smail.nju.edu.cn>
Subject: [PATCH] revision: fix memory leak in prepare_show_merge()
Date: Wed, 04 Jun 2025 03:08:56 +0000 [thread overview]
Message-ID: <pull.1989.git.git.1749006537271.gitgitgadget@gmail.com> (raw)
From: Lidong Yan <502024330056@smail.nju.edu.cn>
In revision.c:prepare_show_merge(), we allocated an array in prune
but forget to free it. Since parse_pathspec is not responsible to
free prune, we should add `free(prune)` in the end of prepare_show_merge().
Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
---
revision: fix memory leak in prepare_show_merge()
In revision.c:prepare_show_merge(), we allocated an array in prune but
forget to free it. Since parse_pathspec is not responsible to free
prune, we should add free(prune) in the end of prepare_show_merge().
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1989%2Fbrandb97%2Ffix-revision-leak-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1989/brandb97/fix-revision-leak-v1
Pull-Request: https://github.com/git/git/pull/1989
revision.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/revision.c b/revision.c
index 2c36a9c179e..afee1111961 100644
--- a/revision.c
+++ b/revision.c
@@ -2060,6 +2060,7 @@ static void prepare_show_merge(struct rev_info *revs)
parse_pathspec(&revs->prune_data, PATHSPEC_ALL_MAGIC & ~PATHSPEC_LITERAL,
PATHSPEC_PREFER_FULL | PATHSPEC_LITERAL_PATH, "", prune);
revs->limited = 1;
+ free(prune);
}
static int dotdot_missing(const char *arg, char *dotdot,
base-commit: 7014b55638da979331baf8dc31c4e1d697cf2d67
--
gitgitgadget
next reply other threads:[~2025-06-04 3:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 3:08 Lidong Yan via GitGitGadget [this message]
2025-06-04 7:48 ` [PATCH] revision: fix memory leak in prepare_show_merge() Patrick Steinhardt
2025-06-04 7:53 ` lidongyan
2025-06-04 8:06 ` Patrick Steinhardt
2025-06-04 10:25 ` lidongyan
2025-06-05 20:56 ` Junio C Hamano
2025-06-06 7:31 ` lidongyan
2025-06-06 16:47 ` Junio C Hamano
2025-06-09 3:10 ` lidongyan
2025-06-09 8:16 ` [PATCH v2] " Lidong Yan via GitGitGadget
2025-06-09 20:48 ` Junio C Hamano
2025-06-10 0:37 ` [PATCH v3] " Lidong Yan via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1989.git.git.1749006537271.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=502024330056@smail.nju.edu.cn \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).