From: "Alex via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Alex <alexguo1023@gmail.com>, jinyaoguo <guo846@purdue.edu>
Subject: [PATCH] Fix memory leak in function handle_content_type
Date: Fri, 13 Jun 2025 16:52:57 +0000 [thread overview]
Message-ID: <pull.1997.git.git.1749833577767.gitgitgadget@gmail.com> (raw)
From: jinyaoguo <guo846@purdue.edu>
The function handle_content_type allocates memory for boundary
using xmalloc(sizeof(struct strbuf)). If (++mi->content_top >=
&mi->content[MAX_BOUNDARIES]) is true, the function returns
without freeing boundary.
Signed-off-by: Alex Guo <alexguo1023@gmail.com>
---
Fix memory leak in function handle_content_type
The function handle_content_type allocates memory for boundary using
xmalloc(sizeof(struct strbuf)). If (++mi->content_top >=
&mi->content[MAX_BOUNDARIES]) is true, the function returns without
freeing boundary.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1997%2Fmugitya03%2Fmlk-2-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1997/mugitya03/mlk-2-v1
Pull-Request: https://github.com/git/git/pull/1997
mailinfo.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mailinfo.c b/mailinfo.c
index ee4597da6be..e0ea358311f 100644
--- a/mailinfo.c
+++ b/mailinfo.c
@@ -266,6 +266,9 @@ static void handle_content_type(struct mailinfo *mi, struct strbuf *line)
error("Too many boundaries to handle");
mi->input_error = -1;
mi->content_top = &mi->content[MAX_BOUNDARIES] - 1;
+ strbuf_release(boundary);
+ free(boundary);
+ boundary = NULL;
return;
}
*(mi->content_top) = boundary;
base-commit: 9edff09aec9b5aaa3d5528129bb279a4d34cf5b3
--
gitgitgadget
next reply other threads:[~2025-06-13 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 16:52 Alex via GitGitGadget [this message]
2025-06-13 16:59 ` [PATCH] Fix memory leak in function handle_content_type Kristoffer Haugsbakk
2025-06-13 18:36 ` Jinyao Guo
2025-06-13 19:06 ` Junio C Hamano
2025-06-13 19:26 ` Jinyao Guo
2025-06-14 16:45 ` Junio C Hamano
2025-06-15 12:55 ` Lidong Yan
2025-06-16 1:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1997.git.git.1749833577767.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=alexguo1023@gmail.com \
--cc=git@vger.kernel.org \
--cc=guo846@purdue.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox