* [PATCH] Document count-objects pack
@ 2025-08-13 9:40 Daniele Sassoli via GitGitGadget
2025-08-14 7:30 ` Kristoffer Haugsbakk
2025-08-14 13:16 ` [PATCH v2] " Daniele Sassoli via GitGitGadget
0 siblings, 2 replies; 7+ messages in thread
From: Daniele Sassoli via GitGitGadget @ 2025-08-13 9:40 UTC (permalink / raw)
To: git; +Cc: Daniele Sassoli, Daniele Sassoli
From: Daniele Sassoli <danielesassoli@gmail.com>
Juno added the printing of "packs" with ae72f685418b.
When 0bdaa1216 refactored the docs for the -v option, this was missed.
Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>
---
Document count-objects -v - packs output
Juno added the printing of "packs" with ae72f68541
[https://github.com/DanieleSassoli/git/commit/ae72f685418b79bbd67e1017c5b1ac7d731c042e].
When 0bdaa1216
[https://github.com/DanieleSassoli/git/commit/0bdaa12169bca5d69f2c58f96cc92d51280e9e26]refactored
the docs for the -v option, this was missed.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2031%2FDanieleSassoli%2Fmaster-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2031/DanieleSassoli/master-v1
Pull-Request: https://github.com/git/git/pull/2031
Documentation/git-count-objects.adoc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/git-count-objects.adoc b/Documentation/git-count-objects.adoc
index 97f9f126101..eeee6b9f7f4 100644
--- a/Documentation/git-count-objects.adoc
+++ b/Documentation/git-count-objects.adoc
@@ -28,6 +28,8 @@ size: disk space consumed by loose objects, in KiB (unless -H is specified)
+
in-pack: the number of in-pack objects
+
+packs: the number of pack files
++
size-pack: disk space consumed by the packs, in KiB (unless -H is specified)
+
prune-packable: the number of loose objects that are also present in
base-commit: 2c2ba49d55ff26c1082b8137b1ec5eeccb4337d1
--
gitgitgadget
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] Document count-objects pack
2025-08-13 9:40 [PATCH] Document count-objects pack Daniele Sassoli via GitGitGadget
@ 2025-08-14 7:30 ` Kristoffer Haugsbakk
2025-08-14 14:46 ` Junio C Hamano
2025-08-14 13:16 ` [PATCH v2] " Daniele Sassoli via GitGitGadget
1 sibling, 1 reply; 7+ messages in thread
From: Kristoffer Haugsbakk @ 2025-08-14 7:30 UTC (permalink / raw)
To: Josh Soref, git; +Cc: Daniele Sassoli
On Wed, Aug 13, 2025, at 11:40, Daniele Sassoli via GitGitGadget wrote:
> From: Daniele Sassoli <danielesassoli@gmail.com>
>
> Juno added the printing of "packs" with ae72f685418b.
> When 0bdaa1216 refactored the docs for the -v option, this was missed.
s/Juno/Junio/
But commits are usually just listed as-is without mentioning authors or
other metadata. Something like this:[1]
ae72f685418 (count-objects -v: show number of packs as well.,
2006-12-27) added `packs` to the output of `-v`. 0bdaa12169b
(git-count-objects.txt: describe each line in -v output, 2013-02-08)
forgot to include `packs`.
The text above is a bit more terse around the commit references since
the subject line for the second commit says what the intent was.
Alternatively, just referencing the second commit:
0bdaa12169b (git-count-objects.txt: describe each line in -v output,
2013-02-08) forgot to include `packs`.
† 1: using “commit-reference” from Documentation/SubmittingPatches
>
> Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] Document count-objects pack
2025-08-14 7:30 ` Kristoffer Haugsbakk
@ 2025-08-14 14:46 ` Junio C Hamano
0 siblings, 0 replies; 7+ messages in thread
From: Junio C Hamano @ 2025-08-14 14:46 UTC (permalink / raw)
To: Kristoffer Haugsbakk; +Cc: Josh Soref, git, Daniele Sassoli
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
> On Wed, Aug 13, 2025, at 11:40, Daniele Sassoli via GitGitGadget wrote:
>> From: Daniele Sassoli <danielesassoli@gmail.com>
>>
>> Juno added the printing of "packs" with ae72f685418b.
>> When 0bdaa1216 refactored the docs for the -v option, this was missed.
>
> s/Juno/Junio/
>
> But commits are usually just listed as-is without mentioning authors or
> other metadata. Something like this:[1]
>
> ae72f685418 (count-objects -v: show number of packs as well.,
> 2006-12-27) added `packs` to the output of `-v`. 0bdaa12169b
> (git-count-objects.txt: describe each line in -v output, 2013-02-08)
> forgot to include `packs`.
>
> The text above is a bit more terse around the commit references since
> the subject line for the second commit says what the intent was.
>
> Alternatively, just referencing the second commit:
>
> 0bdaa12169b (git-count-objects.txt: describe each line in -v output,
> 2013-02-08) forgot to include `packs`.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] Document count-objects pack
2025-08-13 9:40 [PATCH] Document count-objects pack Daniele Sassoli via GitGitGadget
2025-08-14 7:30 ` Kristoffer Haugsbakk
@ 2025-08-14 13:16 ` Daniele Sassoli via GitGitGadget
2025-08-14 13:46 ` Kristoffer Haugsbakk
2025-08-14 14:33 ` [PATCH v3] count-objects: document " Daniele Sassoli via GitGitGadget
1 sibling, 2 replies; 7+ messages in thread
From: Daniele Sassoli via GitGitGadget @ 2025-08-14 13:16 UTC (permalink / raw)
To: git; +Cc: Kristoffer Haugsbakk, Daniele Sassoli, Daniele Sassoli
From: Daniele Sassoli <danielesassoli@gmail.com>
0bdaa12169b (git-count-objects.txt: describe each line in -v output,
2013-02-08) forgot to include `packs`.
Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>
---
Document count-objects -v - packs output
https://github.com/DanieleSassoli/git/commit/0bdaa12169bca5d69f2c58f96cc92d51280e9e26
(git-count-objects.txt: describe each line in -v output, 2013-02-08)
forgot to include packs.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2031%2FDanieleSassoli%2Fmaster-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2031/DanieleSassoli/master-v2
Pull-Request: https://github.com/git/git/pull/2031
Range-diff vs v1:
1: 85bcb142b55 ! 1: 6f0394651c9 Document count-objects pack
@@ Metadata
## Commit message ##
Document count-objects pack
- Juno added the printing of "packs" with ae72f685418b.
- When 0bdaa1216 refactored the docs for the -v option, this was missed.
+ 0bdaa12169b (git-count-objects.txt: describe each line in -v output,
+ 2013-02-08) forgot to include `packs`.
Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>
Documentation/git-count-objects.adoc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/git-count-objects.adoc b/Documentation/git-count-objects.adoc
index 97f9f126101..eeee6b9f7f4 100644
--- a/Documentation/git-count-objects.adoc
+++ b/Documentation/git-count-objects.adoc
@@ -28,6 +28,8 @@ size: disk space consumed by loose objects, in KiB (unless -H is specified)
+
in-pack: the number of in-pack objects
+
+packs: the number of pack files
++
size-pack: disk space consumed by the packs, in KiB (unless -H is specified)
+
prune-packable: the number of loose objects that are also present in
base-commit: 2c2ba49d55ff26c1082b8137b1ec5eeccb4337d1
--
gitgitgadget
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] Document count-objects pack
2025-08-14 13:16 ` [PATCH v2] " Daniele Sassoli via GitGitGadget
@ 2025-08-14 13:46 ` Kristoffer Haugsbakk
2025-08-14 14:33 ` [PATCH v3] count-objects: document " Daniele Sassoli via GitGitGadget
1 sibling, 0 replies; 7+ messages in thread
From: Kristoffer Haugsbakk @ 2025-08-14 13:46 UTC (permalink / raw)
To: Josh Soref, git; +Cc: Daniele Sassoli
On Thu, Aug 14, 2025, at 15:16, Daniele Sassoli via GitGitGadget wrote:
> From: Daniele Sassoli <danielesassoli@gmail.com>
>
> 0bdaa12169b (git-count-objects.txt: describe each line in -v output,
> 2013-02-08) forgot to include `packs`.
>
> Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>
> ---
> Document count-objects -v - packs output
I’m very sorry that I missed this the first time around before you sent
out this new version... but also the subject line
Document count-objects -v - packs output
Should start with a lowercase “area” like e.g.
doc: count-objects: ...
Or:
count-objects: ...
Or some other variation (see `git log --oneline --follow
Documentation/git-count-objects.adoc`).
--
Kristoffer Haugsbakk
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v3] count-objects: document count-objects pack
2025-08-14 13:16 ` [PATCH v2] " Daniele Sassoli via GitGitGadget
2025-08-14 13:46 ` Kristoffer Haugsbakk
@ 2025-08-14 14:33 ` Daniele Sassoli via GitGitGadget
2025-08-14 21:40 ` Junio C Hamano
1 sibling, 1 reply; 7+ messages in thread
From: Daniele Sassoli via GitGitGadget @ 2025-08-14 14:33 UTC (permalink / raw)
To: git; +Cc: Kristoffer Haugsbakk, Daniele Sassoli, Daniele Sassoli
From: Daniele Sassoli <danielesassoli@gmail.com>
0bdaa12169b (git-count-objects.txt: describe each line in -v output,
2013-02-08) forgot to include `packs`.
Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>
---
Document count-objects -v - packs output
https://github.com/DanieleSassoli/git/commit/0bdaa12169bca5d69f2c58f96cc92d51280e9e26
(git-count-objects.txt: describe each line in -v output, 2013-02-08)
forgot to include packs.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2031%2FDanieleSassoli%2Fmaster-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2031/DanieleSassoli/master-v3
Pull-Request: https://github.com/git/git/pull/2031
Range-diff vs v2:
1: 6f0394651c9 ! 1: ab90af2b6a0 Document count-objects pack
@@ Metadata
Author: Daniele Sassoli <danielesassoli@gmail.com>
## Commit message ##
- Document count-objects pack
+ count-objects: document count-objects pack
0bdaa12169b (git-count-objects.txt: describe each line in -v output,
2013-02-08) forgot to include `packs`.
Documentation/git-count-objects.adoc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/git-count-objects.adoc b/Documentation/git-count-objects.adoc
index 97f9f126101..eeee6b9f7f4 100644
--- a/Documentation/git-count-objects.adoc
+++ b/Documentation/git-count-objects.adoc
@@ -28,6 +28,8 @@ size: disk space consumed by loose objects, in KiB (unless -H is specified)
+
in-pack: the number of in-pack objects
+
+packs: the number of pack files
++
size-pack: disk space consumed by the packs, in KiB (unless -H is specified)
+
prune-packable: the number of loose objects that are also present in
base-commit: 2c2ba49d55ff26c1082b8137b1ec5eeccb4337d1
--
gitgitgadget
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v3] count-objects: document count-objects pack
2025-08-14 14:33 ` [PATCH v3] count-objects: document " Daniele Sassoli via GitGitGadget
@ 2025-08-14 21:40 ` Junio C Hamano
0 siblings, 0 replies; 7+ messages in thread
From: Junio C Hamano @ 2025-08-14 21:40 UTC (permalink / raw)
To: Daniele Sassoli via GitGitGadget
Cc: git, Kristoffer Haugsbakk, Daniele Sassoli
"Daniele Sassoli via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Daniele Sassoli <danielesassoli@gmail.com>
>
> 0bdaa12169b (git-count-objects.txt: describe each line in -v output,
> 2013-02-08) forgot to include `packs`.
>
> Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>
> ---
> diff --git a/Documentation/git-count-objects.adoc b/Documentation/git-count-objects.adoc
> index 97f9f126101..eeee6b9f7f4 100644
> --- a/Documentation/git-count-objects.adoc
> +++ b/Documentation/git-count-objects.adoc
> @@ -28,6 +28,8 @@ size: disk space consumed by loose objects, in KiB (unless -H is specified)
> +
> in-pack: the number of in-pack objects
> +
> +packs: the number of pack files
> ++
> size-pack: disk space consumed by the packs, in KiB (unless -H is specified)
> +
> prune-packable: the number of loose objects that are also present in
>
> base-commit: 2c2ba49d55ff26c1082b8137b1ec5eeccb4337d1
Looks good. Thanks. Will queue.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-08-14 21:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-13 9:40 [PATCH] Document count-objects pack Daniele Sassoli via GitGitGadget
2025-08-14 7:30 ` Kristoffer Haugsbakk
2025-08-14 14:46 ` Junio C Hamano
2025-08-14 13:16 ` [PATCH v2] " Daniele Sassoli via GitGitGadget
2025-08-14 13:46 ` Kristoffer Haugsbakk
2025-08-14 14:33 ` [PATCH v3] count-objects: document " Daniele Sassoli via GitGitGadget
2025-08-14 21:40 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).