From: "Md Ferdous Alam via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Md Ferdous Alam <mdferdousalam1989@yahoo.com>,
mdferdousalam <mdferdousalam1989@yahoo.com>
Subject: [PATCH] merge-base, ls-remote, ls-tree: fix error message formatting
Date: Mon, 23 Feb 2026 08:56:19 +0000 [thread overview]
Message-ID: <pull.2053.git.1771836979176.gitgitgadget@gmail.com> (raw)
From: mdferdousalam <mdferdousalam1989@yahoo.com>
The CodingGuidelines state that error messages should not begin
with a capital letter and should not end with a full stop. Fix
the die() messages in builtin/merge-base.c, builtin/ls-remote.c,
and builtin/ls-tree.c that violate these rules.
Signed-off-by: mdferdousalam <mdferdousalam1989@yahoo.com>
---
merge-base, ls-remote, ls-tree: fix error message formatting
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2053%2Fmdferdousalam%2Ffix-error-messages-misc-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2053/mdferdousalam/fix-error-messages-misc-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2053
builtin/ls-remote.c | 2 +-
builtin/ls-tree.c | 2 +-
builtin/merge-base.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c
index fe77829557..51d7579ca1 100644
--- a/builtin/ls-remote.c
+++ b/builtin/ls-remote.c
@@ -128,7 +128,7 @@ int cmd_ls_remote(int argc,
if (!remote) {
if (dest)
die("bad repository '%s'", dest);
- die("No remote configured to list refs from.");
+ die("no remote configured to list refs from");
}
if (get_url) {
diff --git a/builtin/ls-tree.c b/builtin/ls-tree.c
index 113e4a960d..7670aa77a3 100644
--- a/builtin/ls-tree.c
+++ b/builtin/ls-tree.c
@@ -406,7 +406,7 @@ int cmd_ls_tree(int argc,
usage_with_options(ls_tree_usage, ls_tree_options);
if (repo_get_oid_with_flags(the_repository, argv[0], &oid,
GET_OID_HASH_ANY))
- die("Not a valid object name %s", argv[0]);
+ die("not a valid object name %s", argv[0]);
/*
* show_recursive() rolls its own matching code and is
diff --git a/builtin/merge-base.c b/builtin/merge-base.c
index c7ee97fa6a..e337f283f7 100644
--- a/builtin/merge-base.c
+++ b/builtin/merge-base.c
@@ -47,10 +47,10 @@ static struct commit *get_commit_reference(const char *arg)
struct commit *r;
if (repo_get_oid(the_repository, arg, &revkey))
- die("Not a valid object name %s", arg);
+ die("not a valid object name %s", arg);
r = lookup_commit_reference(the_repository, &revkey);
if (!r)
- die("Not a valid commit name %s", arg);
+ die("not a valid commit name %s", arg);
return r;
}
@@ -131,7 +131,7 @@ static int handle_fork_point(int argc, const char **argv)
commitname = (argc == 2) ? argv[1] : "HEAD";
if (repo_get_oid(the_repository, commitname, &oid))
- die("Not a valid object name: '%s'", commitname);
+ die("not a valid object name: '%s'", commitname);
derived = lookup_commit_reference(the_repository, &oid);
base-commit: 7c02d39fc2ed2702223c7674f73150d9a7e61ba4
--
gitgitgadget
reply other threads:[~2026-02-23 8:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.2053.git.1771836979176.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=mdferdousalam1989@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox