[PATCH v2] t2107: modernize path existence check

["QUANTUM via GitGitGadget" <gitgitgadget@gmail.com>]

From: Aditya <adityabnw07@gmail.com>

Replace '! test -f' with 'test_path_is_missing' to get better
debugging information by reporting loudly what expectation was
not met when the assertion fails.

Signed-off-by: Aditya <adityabnw07@gmail.com>
---
    [GSoC PATCH] t2107: modernize path existence check
    
    CC: Pablo Sabater pabloosabaterr@gmail.com, Christian Couder
    christian.couder@gmail.com, Karthik Nayak karthik.188@gmail.com, Justin
    Tobler jltobler@gmail.com, Ayush Chandekar ayu.chandekar@gmail.com,
    Siddharth Asthana siddharthasthana31@gmail.com

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2071%2FQuantumDev-CERN%2Fgsoc-microproject-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2071/QuantumDev-CERN/gsoc-microproject-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/2071

Range-diff vs v1:

 1:  264040c6a8 ! 1:  6ed91f8d9b t2107: modernize path existence check
     @@ Metadata
       ## Commit message ##
          t2107: modernize path existence check
      
     -    Replace '! test -f' with 'test_path_is_missing' for better
     -    debugging information when the assertion fails.
     -
     -    Found using: git grep "test -[efd]" t/t????-*.sh
     +    Replace '! test -f' with 'test_path_is_missing' to get better
     +    debugging information by reporting loudly what expectation was
     +    not met when the assertion fails.
      
          Signed-off-by: Aditya <adityabnw07@gmail.com>
     +    ---
     +    v2:
     +     - remove "Found using" line
     +     - expand description to mention reporting behavior
      
       ## t/t2107-update-index-basic.sh ##
      @@ t/t2107-update-index-basic.sh: test_expect_success '.lock files cleaned up' '


v2:
 - remove "Found using" line
 - expand description to mention reporting behavior
---
 t/t2107-update-index-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t2107-update-index-basic.sh b/t/t2107-update-index-basic.sh
index cc72ead79f..3bffe5da8a 100755
--- a/t/t2107-update-index-basic.sh
+++ b/t/t2107-update-index-basic.sh
@@ -86,7 +86,7 @@ test_expect_success '.lock files cleaned up' '
 	# the_index.cache_changed is zero, rollback_lock_file fails
 	git update-index --refresh --verbose >out &&
 	test_must_be_empty out &&
-	! test -f .git/index.lock
+	test_path_is_missing .git/index.lock
 	)
 '
 

base-commit: ca1db8a0f7dc0dbea892e99f5b37c5fe5861be71
-- 
gitgitgadget