git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Xinyu Ruan via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Xinyu Ruan <r200981113@gmail.com>, Xinyu Ruan <r200981113@gmail.com>
Subject: [PATCH] refs: don't clear oid before read_raw_ref in the debug ref backend
Date: Fri, 31 Oct 2025 03:37:05 +0000	[thread overview]
Message-ID: <pull.2089.git.git.1761881825025.gitgitgadget@gmail.com> (raw)

From: Xinyu Ruan <r200981113@gmail.com>

The debug_read_raw_ref function clears the oid to null_oid before
calling read_raw_ref, which causes the oid to be lost even when
read_raw_ref successfully reads the reference. This leads to failures
when executing commands like "git branch new_branch <commit_id>" with
GIT_TRACE_REFS=1, as the command cannot find a valid branch point
because the oid is null.

Signed-off-by: Xinyu Ruan <r200981113@gmail.com>
---
    refs: don't clear oid before read_raw_ref in the debug ref backend

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2089%2FRuanXinyu%2Fref-debug-disable-clear-oid-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2089/RuanXinyu/ref-debug-disable-clear-oid-v1
Pull-Request: https://github.com/git/git/pull/2089

 refs/debug.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/refs/debug.c b/refs/debug.c
index 697adbd0dc..c8dde3558d 100644
--- a/refs/debug.c
+++ b/refs/debug.c
@@ -227,7 +227,6 @@ static int debug_read_raw_ref(struct ref_store *ref_store, const char *refname,
 	struct debug_ref_store *drefs = (struct debug_ref_store *)ref_store;
 	int res = 0;
 
-	oidcpy(oid, null_oid(ref_store->repo->hash_algo));
 	res = drefs->refs->be->read_raw_ref(drefs->refs, refname, oid, referent,
 					    type, failure_errno);
 

base-commit: a99f379adf116d53eb11957af5bab5214915f91d
-- 
gitgitgadget

             reply	other threads:[~2025-10-31  3:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31  3:37 Xinyu Ruan via GitGitGadget [this message]
2025-10-31  6:48 ` [PATCH] refs: don't clear oid before read_raw_ref in the debug ref backend Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.2089.git.git.1761881825025.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=r200981113@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).