From: "Abhinav Gupta via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Abhinav Gupta <mail@abhinavg.net>, Abhinav Gupta <mail@abhinavg.net>
Subject: [PATCH] sequencer: remove todo_add_branch_context.commit
Date: Mon, 11 May 2026 12:21:53 +0000 [thread overview]
Message-ID: <pull.2111.git.1778502113485.gitgitgadget@gmail.com> (raw)
From: Abhinav Gupta <mail@abhinavg.net>
The 'commit' field in 'struct todo_add_branch_context' is unused.
It's written to, but never read from.
add_decorations_to_list() gets the commit passed to it explicitly
as an argument.
Signed-off-by: Abhinav Gupta <mail@abhinavg.net>
---
sequencer: remove todo_add_branch_context.commit
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2111%2Fabhinav%2Fsequencer-todoctx-rm-commit-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2111/abhinav/sequencer-todoctx-rm-commit-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2111
sequencer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sequencer.c b/sequencer.c
index b7d8dca47f..19839da1e6 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -6409,7 +6409,6 @@ struct todo_add_branch_context {
size_t items_nr;
size_t items_alloc;
struct strbuf *buf;
- struct commit *commit;
struct string_list refs_to_oids;
};
@@ -6498,7 +6497,6 @@ static int todo_list_add_update_ref_commands(struct todo_list *todo_list)
ctx.items[ctx.items_nr++] = todo_list->items[i++];
if (item->commit) {
- ctx.commit = item->commit;
add_decorations_to_list(item->commit, &ctx);
}
}
base-commit: 94f057755b7941b321fd11fec1b2e3ca5313a4e0
--
gitgitgadget
next reply other threads:[~2026-05-11 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 12:21 Abhinav Gupta via GitGitGadget [this message]
2026-05-12 6:36 ` [PATCH] sequencer: remove todo_add_branch_context.commit Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.2111.git.1778502113485.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=mail@abhinavg.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox