From: "Gary Wang via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Gary Wang <git@blumia.net>, Wang Zichong <wangzichong@deepin.org>
Subject: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences
Date: Thu, 26 Feb 2026 12:33:15 +0000 [thread overview]
Message-ID: <pull.2217.git.git.1772109195114.gitgitgadget@gmail.com> (raw)
From: Wang Zichong <wangzichong@deepin.org>
As a dark-theme user, I use the Preferences dialog to set colors
for gitk, the only color I cannot change via that dialog is the
link foreground color, which will lead me to use the default link
color on a dark background that make it not really readable.
This patch makes the link foreground color also configurable in the
Gitk Preferences dialog's Color tab, so user won't need to dig into
the code/manual to know if the link color is configurable and can
simply set the color there.
CC: Mark Levedahl <mlevedahl@gmail.com>, Paul Mackerras <paulus@samba.org>
Signed-off-by: Wang Zichong <wangzichong@deepin.org>
---
gitk: support config the color of linkfgcolor via Gitk Preferences
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2217%2FBLumia%2Fgitk-linkfgcolor-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2217/BLumia/gitk-linkfgcolor-v1
Pull-Request: https://github.com/git/git/pull/2217
gitk-git/gitk | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index cbaaee994e..b60f140636 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -11796,7 +11796,7 @@ proc prefspage_general {notebook} {
proc prefspage_colors {notebook} {
global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor
- global diffbgcolors
+ global diffbgcolors linkfgcolor
global themeloader
set page [create_prefs_page $notebook.colors]
@@ -11873,6 +11873,11 @@ proc prefspage_colors {notebook} {
-command [list choosecolor selectbgcolor {} $page [mc "background"]]
grid x $page.selbgbut $page.selbgsep -sticky w
+ label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor
+ ttk::button $page.linkfgbut -text [mc "Link color"] \
+ -command [list choosecolor linkfgcolor {} $page [mc "link color"]]
+ grid x $page.linkfgbut $page.linkfg -sticky w
+
grid columnconfigure $page 2 -weight 1
return $page
@@ -11880,7 +11885,7 @@ proc prefspage_colors {notebook} {
proc prefspage_set_colorswatches {page} {
global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor
- global diffbgcolors
+ global diffbgcolors linkfgcolor
$page.bg configure -background $bgcolor
$page.fg configure -background $fgcolor
@@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} {
$page.hunksep configure -background [lindex $diffcolors 2]
$page.markbgsep configure -background $markbgcolor
$page.selbgsep configure -background $selectbgcolor
+ $page.linkfg configure -background $linkfgcolor
}
proc prefspage_fonts {notebook} {
base-commit: 7b2bccb0d58d4f24705bf985de1f4612e4cf06e5
--
gitgitgadget
next reply other threads:[~2026-02-26 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 12:33 Gary Wang via GitGitGadget [this message]
2026-02-26 15:25 ` [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences Junio C Hamano
2026-02-27 7:37 ` Johannes Sixt
2026-02-27 16:49 ` Junio C Hamano
2026-02-28 3:37 ` Wang Zichong
2026-02-28 7:51 ` Johannes Sixt
2026-02-28 8:02 ` Wang Zichong
2026-02-28 4:05 ` [PATCH v2] gitk: support link color in the Preferences dialog Gary Wang via GitGitGadget
2026-02-28 7:59 ` [PATCH v3] " Gary Wang via GitGitGadget
2026-03-01 10:30 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.2217.git.git.1772109195114.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@blumia.net \
--cc=git@vger.kernel.org \
--cc=wangzichong@deepin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox