Git development
 help / color / mirror / Atom feed
From: "Kristofer Karlsson via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
	Kristofer Karlsson <krka@spotify.com>
Subject: [PATCH 0/2] t5608: assert that the packs involved really are that large
Date: Fri, 06 Nov 2026 12:51:14 +0000	[thread overview]
Message-ID: <pull.2299.git.1793969476.gitgitgadget@gmail.com> (raw)

I was looking at which tests take the most time in CI, and t5608 stood out
when (unscientifically) spot-checking a single run. Profiling its setup
showed that it does not actually create the >2GB pack that the test's name
promises. While adding assertions for that, it turned out that the
unpack-objects variant of the >4GB test never runs unpack-objects either.

Once it does, it fails on Windows, because unpack-objects narrows the size
of a streamed blob to "unsigned long" on its way to the object writer. The
first patch fixes that.

Kristofer Karlsson (2):
  unpack-objects: pass the size of a streamed blob as size_t
  t5608: assert that the packs involved really are that large

 builtin/unpack-objects.c |  2 +-
 t/t5608-clone-2gb.sh     | 54 ++++++++++++++++++++++++++++++----------
 2 files changed, 42 insertions(+), 14 deletions(-)


base-commit: 0ffa3e35c7c82ab8d0de226149fb03b3f7674d05
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2299%2Fspkrka%2Ft5608-real-2gb-pack-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2299/spkrka/t5608-real-2gb-pack-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2299
-- 
gitgitgadget

             reply	other threads:[~2026-11-06 12:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 12:51 Kristofer Karlsson via GitGitGadget [this message]
2026-11-06 12:51 ` [PATCH 1/2] unpack-objects: pass the size of a streamed blob as size_t Kristofer Karlsson via GitGitGadget
2026-11-06 12:51 ` [PATCH 2/2] t5608: assert that the packs involved really are that large Kristofer Karlsson via GitGitGadget
2026-11-06 14:54   ` Patrick Steinhardt
2026-11-06 15:12     ` Kristofer Karlsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.2299.git.1793969476.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=krka@spotify.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox