From: "Alexandr Miloslavskiy via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/1] t0061: fix test for argv[0] with spaces (MINGW only)
Date: Tue, 01 Oct 2019 04:41:04 -0700 (PDT) [thread overview]
Message-ID: <pull.356.git.gitgitgadget@gmail.com> (raw)
The test was originally designed for the case where user reported that
setting GIT_SSH to a .bat file with spaces in path fails on Windows:
https://github.com/git-for-windows/git/issues/692
The test has two different problems:
1. It succeeds with AND without fix eb7c7863 that addressed user's problem.
This happens because the core problem was misunderstood, leading to
conclusion that git is unable to start any programs with spaces in path
on Win7. But in fact a) Bug only affected cmd.exe scripts, such as .bat
scripts b) Bug only happened when cmd.exe received at least two quoted
args c) Bug happened on any Windows (verified on Win10). Therefore,
correct test must involve .bat script and two quoted args.
2. In Visual Studio build, it fails to run, because 'test-fake-ssh.exe' is
copied away from its dependencies 'libiconv.dll' and 'zlib1.dll'.
Fix both problems by using .bat script instead of 'test-fake-ssh.exe'. NOTE:
With this change, the test now correctly fails without eb7c7863.
Signed-off-by: Alexandr Miloslavskiy alexandr.miloslavskiy@syntevo.com
[alexandr.miloslavskiy@syntevo.com]
Alexandr Miloslavskiy (1):
t0061: fix test for argv[0] with spaces (MINGW only)
t/t0061-run-command.sh | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
base-commit: 4c86140027f4a0d2caaa3ab4bd8bfc5ce3c11c8a
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-356%2FSyntevoAlex%2F%230191_t0061_fixes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-356/SyntevoAlex/#0191_t0061_fixes-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/356
--
gitgitgadget
next reply other threads:[~2019-10-01 11:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 11:41 Alexandr Miloslavskiy via GitGitGadget [this message]
2019-10-01 11:41 ` [PATCH 1/1] t0061: fix test for argv[0] with spaces (MINGW only) Alexandr Miloslavskiy via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.356.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=alexandr.miloslavskiy@syntevo.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).