From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/1] fetch --multiple: respect --jobs=
Date: Sat, 05 Oct 2019 11:46:39 -0700 (PDT) [thread overview]
Message-ID: <pull.369.v2.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.369.git.gitgitgadget@gmail.com>
I saw with sadness that pd/fetch-jobs went nowhere, and read in the most
recent What's Cooking mail that it was even dropped.
This is my attempt to resurrect the idea (although without the overhead of
trying to support a first-class UI to control submodule and multiple-remote
fetches independently, of which I was a rather outspoken opponent).
To make things a bit safer, this patch uses the --end-of-options marker, and
is therefore based on top of jk/eoo.
Changes since v1:
* The regression test now passes even under GETTEXT_POISON.
* The needles used in the regression test are now more indicative of the
code producing them.
Johannes Schindelin (1):
fetch: let --jobs=<n> parallelize --multiple, too
Documentation/config/fetch.txt | 10 +++
Documentation/fetch-options.txt | 13 ++--
builtin/fetch.c | 124 +++++++++++++++++++++++++++-----
t/t5514-fetch-multiple.sh | 11 +++
4 files changed, 137 insertions(+), 21 deletions(-)
base-commit: 67feca3b1c45a51b204253039139b46cc07e145f
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-369%2Fdscho%2Ffetch-jobs-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-369/dscho/fetch-jobs-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/369
Range-diff vs v1:
1: 818936f1e0 ! 1: 93a155a000 fetch: let --jobs=<n> parallelize --multiple, too
@@ -267,9 +267,9 @@
+
+ test_must_fail env GIT_TRACE="$PWD/trace" \
+ git fetch --jobs=2 --multiple one two 2>err &&
-+ grep "2 tasks" trace &&
-+ grep "one.*128" err &&
-+ grep "two.*128" err
++ grep "preparing to run up to 2 tasks" trace &&
++ test_i18ngrep "could not fetch .one.*128" err &&
++ test_i18ngrep "could not fetch .two.*128" err
+'
+
test_done
--
gitgitgadget
next prev parent reply other threads:[~2019-10-05 18:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 11:53 [PATCH 0/1] fetch --multiple: respect --jobs= Johannes Schindelin via GitGitGadget
2019-10-01 11:53 ` [PATCH 1/1] fetch: let --jobs=<n> parallelize --multiple, too Johannes Schindelin via GitGitGadget
2019-10-04 4:33 ` Junio C Hamano
2019-10-04 22:03 ` Johannes Schindelin
2019-10-05 18:46 ` Johannes Schindelin via GitGitGadget [this message]
2019-10-05 18:46 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
[not found] ` <xmqqftk67r6j.fsf@gitster-ct.c.googlers.com>
2019-10-06 9:53 ` Johannes Schindelin
2019-10-07 1:17 ` Junio C Hamano
2019-10-07 10:14 ` Johannes Schindelin
2019-10-07 10:17 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.369.v2.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).