From: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: bturner@atlassian.com, Derrick Stolee <dstolee@microsoft.com>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/1] Move 'git commit-graph read' subcommand to test helper
Date: Tue, 12 Nov 2019 16:58:19 +0000 [thread overview]
Message-ID: <pull.460.git.1573577900.gitgitgadget@gmail.com> (raw)
As discussed [1], the 'git commit-graph read' subcommand has little value to
users and should instead live in a test helper. The implementation was able
to move almost wholesale, with only some new code to find the default object
directory. This was necessary because of some tests that use a bare
repository.
Thanks, -Stolee
[1]
https://public-inbox.org/git/CAGyf7-G3NDp--2nUbri_0EqvSLF21M0gsFCOKDCWMY+e68Htog@mail.gmail.com/
Derrick Stolee (1):
test-tool: use 'read-graph' helper
Documentation/git-commit-graph.txt | 12 ------
Makefile | 1 +
builtin/commit-graph.c | 68 ------------------------------
t/helper/test-read-graph.c | 53 +++++++++++++++++++++++
t/helper/test-tool.c | 1 +
t/helper/test-tool.h | 1 +
t/t5318-commit-graph.sh | 2 +-
t/t5324-split-commit-graph.sh | 2 +-
8 files changed, 58 insertions(+), 82 deletions(-)
create mode 100644 t/helper/test-read-graph.c
base-commit: d9f6f3b6195a0ca35642561e530798ad1469bd41
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-460%2Fderrickstolee%2Fcommit-graph-read-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-460/derrickstolee/commit-graph-read-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/460
--
gitgitgadget
next reply other threads:[~2019-11-12 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 16:58 Derrick Stolee via GitGitGadget [this message]
2019-11-12 16:58 ` [PATCH 1/1] test-tool: use 'read-graph' helper Derrick Stolee via GitGitGadget
2019-11-13 5:31 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.460.git.1573577900.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=bturner@atlassian.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).