From: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Elijah Newren <newren@gmail.com>, Elijah Newren <newren@gmail.com>
Subject: [PATCH] oidset: remove unnecessary include
Date: Sat, 14 Mar 2020 19:15:47 +0000 [thread overview]
Message-ID: <pull.727.git.git.1584213347500.gitgitgadget@gmail.com> (raw)
From: Elijah Newren <newren@gmail.com>
When commit 8b2f8cbcb1 ("oidset: use khash", 2018-10-04) moved from
using oidmap to khash, it replaced the oidmap.h include with both one
for hashmap.h and khash.h. Since the hashmap.h header is unnecessary,
and the point of the patch was to switch from hashmap (used by oidmap)
to khash.h, remove the unneccessary include.
Signed-off-by: Elijah Newren <newren@gmail.com>
---
oidset: remove unnecessary include
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-727%2Fnewren%2Foidset-cleanup-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-727/newren/oidset-cleanup-v1
Pull-Request: https://github.com/git/git/pull/727
oidset.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/oidset.h b/oidset.h
index 5346563b0bc..d8a106b1275 100644
--- a/oidset.h
+++ b/oidset.h
@@ -1,7 +1,6 @@
#ifndef OIDSET_H
#define OIDSET_H
-#include "hashmap.h"
#include "khash.h"
/**
base-commit: 30e9940356dc67959877f4b2417da33ebdefbb79
--
gitgitgadget
next reply other threads:[~2020-03-15 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 19:15 Elijah Newren via GitGitGadget [this message]
2020-03-16 19:28 ` [PATCH] oidset: remove unnecessary include Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.727.git.git.1584213347500.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).