From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH] GitHub workflow: automatically follow minor updates of setup-msbuild
Date: Wed, 07 Oct 2020 08:17:49 +0000 [thread overview]
Message-ID: <pull.744.git.1602058669919.gitgitgadget@gmail.com> (raw)
From: Johannes Schindelin <johannes.schindelin@gmx.de>
It is the custom to follow minor updates of GitHub Actions
automatically, by using the suffix `@v1`. Actions' maintainers will then
update that `v1` ref to point to the newest.
However, for `microsoft/setup-msbuild`, 889cacb6897 (ci: configure
GitHub Actions for CI/PR, 2020-04-11) uses a very specific `@v1.0.0`
suffix.
In this instance, that is a problem: should `setup-msbuild` release a
new version that intends to fix a critical bug, we won't know it, and we
won't use it.
Such a scenario is not theoretical. It is happening right now:
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands
Let's simplify our setup, allowing us to benefit from automatically
using the newest v1.x.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
GitHub workflow: automatically follow minor updates of setup-msbuild
This patch was based on dd/ci-swap-azure-pipelines-with-github-actions,
but due to changes outside of Git, that GitHub workflow does not even
begin to work anymore. Therefore, the patch is now actually based on
master.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-744%2Fdscho%2Fsimplify-setup-msbuild-upgrades-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-744/dscho/simplify-setup-msbuild-upgrades-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/744
.github/workflows/main.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index fcfd138ff1..14ff94dcbe 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -154,7 +154,7 @@ jobs:
Expand-Archive compat.zip -DestinationPath . -Force
Remove-Item compat.zip
- name: add msbuild to PATH
- uses: microsoft/setup-msbuild@v1.0.0
+ uses: microsoft/setup-msbuild@v1
- name: copy dlls to root
shell: powershell
run: |
base-commit: d98273ba77e1ab9ec755576bc86c716a97bf59d7
--
gitgitgadget
next reply other threads:[~2020-10-07 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 8:17 Johannes Schindelin via GitGitGadget [this message]
2020-10-07 12:49 ` [PATCH] GitHub workflow: automatically follow minor updates of setup-msbuild Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.744.git.1602058669919.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).