git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/2] mingw: fix git clone \\server\share
Date: Thu, 17 Jan 2019 12:14:46 -0800 (PST)	[thread overview]
Message-ID: <pull.94.git.gitgitgadget@gmail.com> (raw)

Due to quirks in the MSYS2 runtime intended to help interpret a command-line
as if it had been pre-processed by a shell, the backslashes would be
misinterpreted as if they were escape characters. This showed most
prominently when trying to clone from a network share, as the path would
start with two backslashes.

These patches have been carried in Git for Windows for more than
one-and-a-half years (in a slightly different, less readable form), and it
is time to bring them home.

Johannes Schindelin (2):
  mingw (t5580): document bug when cloning from backslashed UNC paths
  mingw: special-case arguments to `sh`

 compat/mingw.c            | 77 ++++++++++++++++++++++++++++++++++++++-
 t/t0061-run-command.sh    | 10 +++++
 t/t5580-clone-push-unc.sh |  5 +++
 3 files changed, 91 insertions(+), 1 deletion(-)


base-commit: 77556354bb7ac50450e3b28999e3576969869068
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-94%2Fdscho%2Func-path-w-backslashes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-94/dscho/unc-path-w-backslashes-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/94
-- 
gitgitgadget

             reply	other threads:[~2019-01-17 20:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 20:14 Johannes Schindelin via GitGitGadget [this message]
2019-01-17 20:14 ` [PATCH 1/2] mingw (t5580): document bug when cloning from backslashed UNC paths Johannes Schindelin via GitGitGadget
2019-01-17 20:14 ` [PATCH 2/2] mingw: special-case arguments to `sh` Johannes Schindelin via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.94.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).