From: "Utku Gultopu via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Utku Gultopu <ugultopu@gmail.com>,
Utku Gultopu <ugultopu@gmail.com>
Subject: [PATCH v2] doc: `--date` in `git-commit` accepts approxidates
Date: Tue, 23 Feb 2021 18:52:02 +0000 [thread overview]
Message-ID: <pull.969.v2.git.git.1614106322760.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.969.git.git.1614101746491.gitgitgadget@gmail.com>
From: Utku Gultopu <ugultopu@gmail.com>
Document the fact that the `--date` option in `git-commit` accepts any
date format that is accepted by the `approxidate_careful` function,
which is located in `date.c`.
Signed-off-by: Utku Gultopu <ugultopu@gmail.com>
---
doc: --date in git-commit accepts approxidates
Without the documentation, it is kind of a "hidden feature", which I was
able to discover only through online forums.
I guess this patch is not ideal, because instead of properly
documenting, it refers the user to the code. However I wasn't able to
find documentation about the "approxidates" which I can link to. Please
let me know how I can improve it.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-969%2Fugultopu%2Fdocument-approxidates-for-date-argument-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-969/ugultopu/document-approxidates-for-date-argument-v2
Pull-Request: https://github.com/git/git/pull/969
Range-diff vs v1:
1: 9116ad67a0c6 ! 1: e564d7d9af3d doc: `--date` in `git-commit` accepts approxidates
@@ Commit message
## Documentation/date-formats.txt ##
@@
--DATE FORMATS
--------------
-+DATE FORMATS[[DATES]]
-+---------------------
+ DATE FORMATS
+ ------------
-The `GIT_AUTHOR_DATE`, `GIT_COMMITTER_DATE` environment variables
-ifdef::git-commit[]
@@ Documentation/date-formats.txt
support the following date formats:
Git internal format::
-
- ## Documentation/git-commit.txt ##
-@@ Documentation/git-commit.txt: OPTIONS
- the commit author is then copied from the first such commit found.
-
- --date=<date>::
-- Override the author date used in the commit.
-+ Override the author date used in the commit. The '<date>' can be in
-+ any format that is accepted by the `approxidate_careful` function
-+ in `date.c` or the <<DATES, DATE FORMATS>> section below.
-
- -m <msg>::
- --message=<msg>::
+@@ Documentation/date-formats.txt: ISO 8601::
+ +
+ NOTE: In addition, the date part is accepted in the following formats:
+ `YYYY.MM.DD`, `MM/DD/YYYY` and `DD.MM.YYYY`.
++
++ifdef::git-commit[]
++In addition to recognizing all date formats above, the `--date` option
++will also try to make sense of other, more human-centric date formats,
++such as relative dates like "yesterday" or "last Friday at noon". For
++further details on what kind of formats are accepted, please refer to
++the `approxidate_careful` function in `date.c` file in Git source code.
++endif::git-commit[]
Documentation/date-formats.txt | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/Documentation/date-formats.txt b/Documentation/date-formats.txt
index f1097fac69a6..b86a5a25fe46 100644
--- a/Documentation/date-formats.txt
+++ b/Documentation/date-formats.txt
@@ -1,10 +1,7 @@
DATE FORMATS
------------
-The `GIT_AUTHOR_DATE`, `GIT_COMMITTER_DATE` environment variables
-ifdef::git-commit[]
-and the `--date` option
-endif::git-commit[]
+The `GIT_AUTHOR_DATE` and `GIT_COMMITTER_DATE` environment variables
support the following date formats:
Git internal format::
@@ -26,3 +23,11 @@ ISO 8601::
+
NOTE: In addition, the date part is accepted in the following formats:
`YYYY.MM.DD`, `MM/DD/YYYY` and `DD.MM.YYYY`.
+
+ifdef::git-commit[]
+In addition to recognizing all date formats above, the `--date` option
+will also try to make sense of other, more human-centric date formats,
+such as relative dates like "yesterday" or "last Friday at noon". For
+further details on what kind of formats are accepted, please refer to
+the `approxidate_careful` function in `date.c` file in Git source code.
+endif::git-commit[]
base-commit: 966e671106b2fd38301e7c344c754fd118d0bb07
--
gitgitgadget
next prev parent reply other threads:[~2021-02-23 18:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 17:35 [PATCH] doc: `--date` in `git-commit` accepts approxidates Utku Gultopu via GitGitGadget
2021-02-23 18:11 ` Jeff King
2021-02-23 19:33 ` Junio C Hamano
2021-02-23 18:52 ` Utku Gultopu via GitGitGadget [this message]
2021-02-23 19:06 ` [PATCH v2] " Jeff King
[not found] ` <CAEeqB6kqZTft9NWtOvm3hk9bicBL7GU_WYuAGdMG1MHYMgNAxg@mail.gmail.com>
2021-02-23 19:16 ` Utku
2021-02-23 19:34 ` Junio C Hamano
2021-02-23 20:24 ` Utku
2021-02-23 20:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.969.v2.git.git.1614106322760.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ugultopu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).