From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Ramsay Jones" <ramsay@ramsayjones.plus.com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: [PATCH] ci: run `make sparse` as a GitHub workflow
Date: Tue, 13 Jul 2021 11:51:26 +0000 [thread overview]
Message-ID: <pull.994.git.1626177086682.gitgitgadget@gmail.com> (raw)
From: Johannes Schindelin <johannes.schindelin@gmx.de>
Occasionally we receive reviews after patches were integrated, where
`sparse` identified problems such as file-local variables or functions
being declared as global.
By running `sparse` as part of our Continuous Integration, we can catch
such things much earlier. Even better: developers who activated GitHub
Actions on their forks can catch such issues before even sending their
patches to the Git mailing list.
This addresses https://github.com/gitgitgadget/git/issues/345
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
ci: run make sparse as a GitHub workflow
One of the earliest open source static analyzers is called "sparse", and
occasionally Ramsay Jones sends out mails on the Git mailing list that
some function or other should be declared static because sparse found
out that it is only used within the same file.
Let's add a GitHub workflow running "make sparse".
Example run: https://github.com/gitgitgadget/git/actions/runs/1026303823
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-994%2Fdscho%2Fci-enable-sparse-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-994/dscho/ci-enable-sparse-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/994
.github/workflows/run-sparse.yml | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 .github/workflows/run-sparse.yml
diff --git a/.github/workflows/run-sparse.yml b/.github/workflows/run-sparse.yml
new file mode 100644
index 00000000000..25f6a6efb40
--- /dev/null
+++ b/.github/workflows/run-sparse.yml
@@ -0,0 +1,22 @@
+name: Run `sparse`
+
+on: [push, pull_request]
+
+jobs:
+ sparse:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Download the `sparse` package
+ uses: git-for-windows/get-azure-pipelines-artifact@v0
+ with:
+ repository: git/git
+ definitionId: 10
+ artifact: sparse-20.04
+ - name: Install the `sparse` package
+ run: sudo dpkg -i sparse-20.04/sparse_*.deb
+ - name: Install a couple of dependencies
+ run: |
+ sudo apt-get install -q -y libssl-dev libcurl4-openssl-dev libexpat-dev gettext zlib1g-dev
+ - uses: actions/checkout@v2
+ - name: make sparse
+ run: make sparse
\ No newline at end of file
base-commit: ebf3c04b262aa27fbb97f8a0156c2347fecafafb
--
gitgitgadget
next reply other threads:[~2021-07-13 11:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 11:51 Johannes Schindelin via GitGitGadget [this message]
2021-07-13 16:55 ` [PATCH] ci: run `make sparse` as a GitHub workflow Đoàn Trần Công Danh
2021-07-14 9:12 ` Johannes Schindelin
2021-07-13 17:34 ` Philippe Blain
2021-07-14 9:09 ` Johannes Schindelin
2021-07-14 10:13 ` Johannes Schindelin
2021-07-16 1:37 ` Ramsay Jones
2021-07-13 22:41 ` Junio C Hamano
2021-07-14 10:09 ` Johannes Schindelin
2021-07-14 16:00 ` Junio C Hamano
2021-07-14 20:54 ` Johannes Schindelin
2021-07-14 20:56 ` Junio C Hamano
2021-07-14 22:03 ` Johannes Schindelin
2021-07-14 22:27 ` Junio C Hamano
2021-07-16 15:25 ` Johannes Schindelin
2021-07-16 16:42 ` Junio C Hamano
2021-07-14 11:50 ` [PATCH v2] ci: run `make sparse` as part of the " Johannes Schindelin via GitGitGadget
2021-07-26 17:53 ` [PATCH] ci: run "apt-get update" before "apt-get install" Jeff King
2021-07-26 18:22 ` Jeff King
2021-07-26 22:12 ` Junio C Hamano
2021-07-26 20:27 ` [PATCH v3] ci: run `make sparse` as part of the GitHub workflow Johannes Schindelin via GitGitGadget
2021-07-26 22:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.994.git.1626177086682.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).