From: Tay Ray Chuan <rctay89@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/2] wt-status: take advice.statusHints seriously
Date: Fri, 23 Apr 2010 12:15:56 +0800 [thread overview]
Message-ID: <q2ibe6fef0d1004222115gcdd8fd81xce8993508bfa9f5d@mail.gmail.com> (raw)
In-Reply-To: <86a4d8e5df80008c5c2b3ff4f2a5842ad1f58dc4.1271968072.git.git@drmicha.warpmail.net>
Hi,
On Fri, Apr 23, 2010 at 4:30 AM, Michael J Gruber
<git@drmicha.warpmail.net> wrote:
> else if (s->untracked.nr)
> - printf("nothing added to commit but untracked files present (use \"git add\" to track)\n");
> + printf("nothing added to commit but untracked files present%s\n",
> + advice_status_hints
> + ? " (use \"git add\" to track)" : "");
while we're at it, perhaps we could put the hints on its own line,
with a "hint: " prefix:
nothing added to commit but untracked files present
hint: use "git add" to track
This way, we give future git usability hackers the space to elaborate
further on why a certain flag or command was recommended.
--
Cheers,
Ray Chuan
next prev parent reply other threads:[~2010-04-23 4:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 14:47 [RFC/RFD] wt-status: take advice.statusHints seriously Michael J Gruber
2010-04-22 7:48 ` Junio C Hamano
2010-04-22 20:30 ` [PATCH 1/2] t7508: test advice.statusHints Michael J Gruber
2010-04-22 20:30 ` [PATCH 2/2] wt-status: take advice.statusHints seriously Michael J Gruber
2010-04-23 4:15 ` Tay Ray Chuan [this message]
2010-04-23 8:09 ` Michael J Gruber
2010-04-23 18:31 ` Jakub Narebski
2010-04-26 19:10 ` Jeff King
2010-04-26 19:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q2ibe6fef0d1004222115gcdd8fd81xce8993508bfa9f5d@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).