From: Erik Faye-Lund <kusmabite@googlemail.com>
To: Gerhard Wiesinger <lists@wiesinger.com>
Cc: Thomas Rast <trast@student.ethz.ch>, git@vger.kernel.org
Subject: Re: Global .git directory
Date: Wed, 28 Apr 2010 14:50:46 +0200 [thread overview]
Message-ID: <q2k40aa078e1004280550o322dc5b8jca74d401a5eb1abe@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1004280710380.27548@bbs.intern>
On Wed, Apr 28, 2010 at 7:33 AM, Gerhard Wiesinger <lists@wiesinger.com> wrote:
> On Tue, 27 Apr 2010, Erik Faye-Lund wrote:
>
>> On Tue, Apr 27, 2010 at 10:06 PM, Gerhard Wiesinger <lists@wiesinger.com>
>> wrote:
>>>
>>> On Tue, 27 Apr 2010, Thomas Rast wrote:
>>>>
>>>> (In other words, please convince us that this is actually worth
>>>> having.)
>>>
>>> Ok, rather than convincing I've written a (fast) patch which works for me
>>> :-)
>>>
>>> Any comments? Any (further) changes needed? Will you include it in main
>>> git?
>>
>> Please see Documentation/SubmittingPatches. It's difficult to comment
>> on a non-inlined patch.
>>
>
> Patch done on top of HEAD.
> git format-patch -M origin/master
> 0001-Added-global-git-directory-when-environment-variable.patch
> 0002-Added-global-git-directory-when-environment-variable.patch
> 0003-Updated-documentation-for-submitting-patches.patch
> Attached.
>
I was referring to that you sent the patch attached instead of inlined
(as Documentation/SubmittingPatches suggests).
By attaching patches you force everyone who wants to review the patch
to have to copy and manually quote the parts of the patch that they
have comments about instead of automatic quoting like all decent
e-mail clients do. That way you get less people interested in the
patch.
I sent this reply because you did the right thing of cooking up a
patch in the first place (as opposed to just arguing - very good), so
I think you deserve a chance of getting the patch reviewed (and
possibly included... if people agree with you, that is).
--
Erik "kusma" Faye-Lund
next prev parent reply other threads:[~2010-04-28 12:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 5:14 Global .git directory Gerhard Wiesinger
2010-04-27 9:59 ` Thomas Rast
2010-04-27 20:06 ` Gerhard Wiesinger
2010-04-27 20:26 ` Erik Faye-Lund
2010-04-28 5:33 ` Gerhard Wiesinger
2010-04-28 6:22 ` Tomas Carnecky
2010-04-28 20:03 ` Gerhard Wiesinger
2010-04-28 8:01 ` Alex Riesen
2010-04-28 20:10 ` Gerhard Wiesinger
2010-04-28 12:50 ` Erik Faye-Lund [this message]
2010-04-28 20:22 ` Gerhard Wiesinger
2010-05-04 5:07 ` Gerhard Wiesinger
2010-05-04 5:40 ` Andrew Ruder
2010-05-04 6:02 ` Andreas Ericsson
2010-05-04 6:07 ` Gerhard Wiesinger
2010-05-04 16:55 ` Junio C Hamano
2010-04-27 20:37 ` Jacob Helwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q2k40aa078e1004280550o322dc5b8jca74d401a5eb1abe@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=lists@wiesinger.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).