From: Bert Wesarg <bert.wesarg@googlemail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH] git-gui: Fast staging/unstaging of hunks/lines
Date: Mon, 12 Apr 2010 08:49:01 +0200 [thread overview]
Message-ID: <q2m36ca99e91004112349l9e336fffl7e69bb75bce07a40@mail.gmail.com> (raw)
In-Reply-To: <201004112101.54908.j6t@kdbg.org>
Hi,
On Sun, Apr 11, 2010 at 21:01, Johannes Sixt <j6t@kdbg.org> wrote:
> On Sonntag, 11. April 2010, Bert Wesarg wrote:
>> On Mon, Apr 5, 2010 at 11:01, Bert Wesarg <bert.wesarg@googlemail.com>
> wrote:
>> > This adds a shortcut to stage/unstage hunks or a range of lines. Which is
>> > done on a mouse button 1 release event and holding the control key in the
>> > diff view. If there is currently a selection only the selected lines will
>> > be staged/unstaged. Otherwise the hunk will be staged/unstaged.
>>
>> Ping.
>
> I gave the patch a quick try.
Thanks,
>
> I don't think that I would use it a lot because it is very easy to mess up a
> staged change: The problem is that a click without anything selected will
> stage an entire hunk. I frequently use "Stage Line(s)" to separate
> neighboring changes that must go to separate commits, but with you feature it
> is very easy to forget to select something and, hence, to stage the entire
> hunk accidentally - which means that I would have to start over with the hunk
> and all the "quick" aspects of the feature would be lost.
I don't feel comfortable with this ambiguity myself. I see two ways to
solve this:
a) Use Shift-Button-1 for lines
or
b) Use Shift-Control-Button-1 for lines
and make Control-Button-1 only stage hunks.
May this interface be more usable?
Regards,
Bert
> -- Hannes
>
next prev parent reply other threads:[~2010-04-12 6:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 9:01 [PATCH] git-gui: Fast staging/unstaging of hunks/lines Bert Wesarg
2010-04-11 7:38 ` Bert Wesarg
2010-04-11 19:01 ` Johannes Sixt
2010-04-12 6:49 ` Bert Wesarg [this message]
2010-04-12 17:45 ` Johannes Sixt
2010-04-12 17:55 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q2m36ca99e91004112349l9e336fffl7e69bb75bce07a40@mail.gmail.com \
--to=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).