git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bo Yang <struggleyb.nku@gmail.com>
To: Yann Dirson <dirson@bertin.fr>
Cc: git@vger.kernel.org, ydirson@free.fr
Subject: Re: [PATCH 2/2] Change the description of '-M' and '-C' option.
Date: Thu, 8 Apr 2010 22:15:50 -0700	[thread overview]
Message-ID: <q2y41f08ee11004082215y3cf6c581i3673b1dcc8bb3f37@mail.gmail.com> (raw)
In-Reply-To: <20100408100719.7fc89300@chalon.bertin.fr>

Hi Yann,
On Thu, Apr 8, 2010 at 1:07 AM, Yann Dirson <dirson@bertin.fr> wrote:
> Very interesting addition, indeed - thanks much.
>
> Some information may still be missing, though:
>
> - the default value of the numeric argument to -M/-C
> - the meaning of numeric arguments to the various flags when several
>  are given (eg. what does "blame -M10 -C5 -C15" mean ?)
> - the numeric arguments are not visible in the summary

Ah, thanks a lot for these advice, I will add them on next version of
this patch.

> On another aspect, given the nature of repetitive -C we may want to warn
> the user of bomb out if more than 3 occurences of the flag happen ?

En, sound rationale, I think. I will try another patch to add this. Thanks!

Regards!
Bo

  reply	other threads:[~2010-04-09  5:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08  8:07 [PATCH 2/2] Change the description of '-M' and '-C' option Yann Dirson
2010-04-09  5:15 ` Bo Yang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-04-08  6:51 [PATCH 0/2] Document update for 'git-blame' " Bo Yang
2010-04-08  6:51 ` [PATCH 1/2] Add a basic idea section for git-blame Bo Yang
2010-04-08  6:51   ` [PATCH 2/2] Change the description of '-M' and '-C' option Bo Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=q2y41f08ee11004082215y3cf6c581i3673b1dcc8bb3f37@mail.gmail.com \
    --to=struggleyb.nku@gmail.com \
    --cc=dirson@bertin.fr \
    --cc=git@vger.kernel.org \
    --cc=ydirson@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).