git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karl Chen <quarl@cs.berkeley.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] Support diff.autorefreshindex=true in `git-diff --quiet'
Date: Mon, 01 Sep 2008 03:50:29 -0700	[thread overview]
Message-ID: <quack.20080901T0350.lthzlmsgmx6@roar.cs.berkeley.edu> (raw)
In-Reply-To: <7vskskw41j.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Mon\, 01 Sep 2008 03\:31\:36 -0700")

>>>>> On 2008-09-01 03:31 PDT, Junio C Hamano writes:

    Junio> Karl Chen <quarl@cs.berkeley.edu> writes:
    >> When diff.autorefreshindex is true, if a file has merely
    >> been 'touched' (mtime changed, but contents unchanged),
    >> then `git-diff --quiet' will now return 0 (indicating no
    >> change) instead of 1, and also silently refresh the index.

    Junio> My knee-jerk reaction is that I do not particularly
    Junio> like this, but I haven't thought things through.  What
    Junio> does --exit-code do with or without the configuration
    Junio> variable?

git diff --exit-code silently refreshes the index and returns 0,
as documented and as I expect.  So I further expect "git diff
--exit-code --quiet" to be have the same semantics as "git diff
--exit-code >/dev/null".

What don't you like about this?  Isn't this the point of
diff.autorefreshindex ?

  reply	other threads:[~2008-09-01 10:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01  8:29 [PATCH] Support diff.autorefreshindex=true in `git-diff --quiet' Karl Chen
2008-09-01 10:31 ` Junio C Hamano
2008-09-01 10:50   ` Karl Chen [this message]
2008-09-02  6:20     ` Re* " Junio C Hamano
2008-09-02 17:39       ` Karl Chen
2008-09-02 17:47         ` Junio C Hamano
2008-09-02 17:59           ` Karl Chen
2008-09-02 20:19             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=quack.20080901T0350.lthzlmsgmx6@roar.cs.berkeley.edu \
    --to=quarl@cs.berkeley.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).