git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karl Chen <quarl@cs.berkeley.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] Support diff.autorefreshindex=true in `git-diff --quiet'
Date: Tue, 02 Sep 2008 10:39:47 -0700	[thread overview]
Message-ID: <quack.20080902T1039.lthabeqmopo_-_@roar.cs.berkeley.edu> (raw)
In-Reply-To: <7vy72bnk5x.fsf_-_@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Mon\, 01 Sep 2008 23\:20\:26 -0700")

>>>>> On 2008-09-01 23:20 PDT, Junio C Hamano writes:

    Junio> Looking at your patch and thinking about the issue very
    Junio> much tempt me to suggest the attached patch which is at
    Junio> the other extreme of the spectrum.

I think it is the extreme at the same end of the spectrum and I
like it.  (I was tempted to do this but thought there was a reason
those options were ignored by --quiet.)  This is good because it
makes --quiet do what one thinks it does, and what's documented,
with no exceptions (i.e. equivalent to --exit-code > /dev/null).

If anyone actually used the old behavior of ignoring
diff.autorefreshindex (as an optimization, because the script ran
update-index --refresh outside a loop), there could be a --quick
option, or they could use git-diff-files.

  reply	other threads:[~2008-09-02 17:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01  8:29 [PATCH] Support diff.autorefreshindex=true in `git-diff --quiet' Karl Chen
2008-09-01 10:31 ` Junio C Hamano
2008-09-01 10:50   ` Karl Chen
2008-09-02  6:20     ` Re* " Junio C Hamano
2008-09-02 17:39       ` Karl Chen [this message]
2008-09-02 17:47         ` Junio C Hamano
2008-09-02 17:59           ` Karl Chen
2008-09-02 20:19             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=quack.20080902T1039.lthabeqmopo_-_@roar.cs.berkeley.edu \
    --to=quarl@cs.berkeley.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).