From: Alex Riesen <raa.lkml@gmail.com>
To: "Daniel Richard G." <skunk@iskunk.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Building Git on Tru64
Date: Thu, 15 Apr 2010 21:29:11 +0200 [thread overview]
Message-ID: <r2n81b0412b1004151229g6fe840a1v23a9d06f72e8d36a@mail.gmail.com> (raw)
In-Reply-To: <1271358589.19032.1370170305@webmail.messagingengine.com>
On Thu, Apr 15, 2010 at 21:09, Daniel Richard G. <skunk@iskunk.org> wrote:
> * On Tru64, MAP_FAILED is #defined as (-1L), and the compiler chokes if
> you directly compare a pointer to an integer. So, need to cast
> MAP_FAILED to (void *), redundant as that may seem.
That one may be better handled at one place (git-compat-util.h?) with
something like:
#ifdef Tru64
#define MAP_FAILED ((void *)MAP_FAILED)
#endif
P.S. You may consider reading Documentation/SubmittingPatches.
The way you did it is a little unconventional.
next prev parent reply other threads:[~2010-04-15 19:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 19:09 [PATCH] Building Git on Tru64 Daniel Richard G.
2010-04-15 19:29 ` Alex Riesen [this message]
2010-04-15 19:46 ` Daniel Richard G.
2010-04-15 20:04 ` Nicolas Pitre
2010-04-15 20:21 ` Daniel Richard G.
2010-04-15 21:24 ` Jakub Narebski
2010-04-16 6:58 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=r2n81b0412b1004151229g6fe840a1v23a9d06f72e8d36a@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=skunk@iskunk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).