From: Stefan Hajnoczi <stefanha@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Michael J Gruber <git@drmicha.warpmail.net>, git@vger.kernel.org
Subject: Re: Local unset override global options
Date: Mon, 12 Apr 2010 09:43:35 +0100 [thread overview]
Message-ID: <r2vfbd9d3991004120143td6f90410j60c7c002b15d5db6@mail.gmail.com> (raw)
In-Reply-To: <7vk4sdm5kw.fsf@alter.siamese.dyndns.org>
On Mon, Apr 12, 2010 at 9:35 AM, Junio C Hamano <gitster@pobox.com> wrote:
> @@ -1043,7 +1043,7 @@ X-Mailer: git-send-email $gitversion
> defined $smtp_server_port ? "port=$smtp_server_port" : "";
> }
>
> - if (defined $smtp_authuser) {
> + if (defined $smtp_authuser && $smtp_authuser ne '') {
>
> if (!defined $smtp_authpass) {
>
That would work but introduces a special case for smtpuser. Do you
think users may wish to unset override other options too?
Stefan
next prev parent reply other threads:[~2010-04-12 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-10 6:54 Local unset override global options Stefan Hajnoczi
2010-04-12 8:13 ` Michael J Gruber
2010-04-12 8:23 ` Stefan Hajnoczi
2010-04-12 8:28 ` Michael J Gruber
2010-04-12 8:53 ` Jakub Narebski
2010-04-12 15:47 ` Junio C Hamano
2010-04-12 17:02 ` Jakub Narebski
2010-04-12 18:18 ` Junio C Hamano
2010-04-12 18:36 ` Erik Faye-Lund
2010-04-12 21:07 ` Jakub Narebski
2010-04-12 8:35 ` Junio C Hamano
2010-04-12 8:43 ` Stefan Hajnoczi [this message]
2010-04-12 15:48 ` Junio C Hamano
2010-04-12 16:07 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=r2vfbd9d3991004120143td6f90410j60c7c002b15d5db6@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).