From: Peter Baumann <Peter.B.Baumann@stud.informatik.uni-erlangen.de>
To: git@vger.kernel.org
Subject: Re: [PATCH] config option core.showroot to enable showing the diff of the root commit
Date: Fri, 24 Nov 2006 00:34:35 +0100 [thread overview]
Message-ID: <slrnemcc0b.ncc.Peter.B.Baumann@xp.machine.xx> (raw)
In-Reply-To: 7virh5khrc.fsf@assigned-by-dhcp.cox.net
On 2006-11-23, Junio C Hamano <junkio@cox.net> wrote:
> Peter Baumann <Peter.B.Baumann@stud.informatik.uni-erlangen.de>
> writes:
>
>> This allows one to see the root commit as a diff in commands like git-log,
>> git-show and git-whatchanged. It also modifies git-diff-tree to act as --root
>> was specified on the commandline. The default is set to true.
>>
>> Signed-off-by: Peter Baumann <Peter.B.Baumannn@stud.informatik.uni-erlangen.de>
>> ---
>> I'm not sure if making core.showroot acting on git-diff-tree is the
>> right thing to do. Please check first bevore applying.
>
> I agree that this "use --root by default" belongs to Porcelain
> layer, not the plumbing. We would probably want to do this in
> the same way as we do the color in diff.c::git_diff_ui_config().
>
Sorry, but I don't understand. The color handling doesn't look any different
to me than the handling of the other config entrys. Did I miss something?
Peter
next prev parent reply other threads:[~2006-11-23 23:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 13:41 git-show --stat on first commit Andy Parkins
2006-11-21 14:01 ` Jakub Narebski
2006-11-21 14:09 ` Santi Béjar
2006-11-21 16:08 ` Peter Baumann
2006-11-21 16:18 ` Jakub Narebski
2006-11-21 17:16 ` Peter Baumann
2006-11-21 18:14 ` Horst H. von Brand
2006-11-21 16:31 ` Linus Torvalds
2006-11-21 16:47 ` Shawn Pearce
2006-11-21 17:11 ` Peter Baumann
2006-11-21 17:20 ` Linus Torvalds
2006-11-21 18:38 ` Olivier Galibert
2006-11-21 18:42 ` Shawn Pearce
2006-11-21 19:05 ` Petr Baudis
2006-11-21 18:06 ` Petr Baudis
2006-11-21 18:16 ` Jakub Narebski
2006-11-21 18:21 ` Petr Baudis
2006-11-21 18:34 ` Shawn Pearce
2006-11-21 18:39 ` Andy Parkins
2006-11-21 18:48 ` Petr Baudis
2006-11-21 18:52 ` Shawn Pearce
2006-11-21 19:04 ` Petr Baudis
2006-11-21 19:31 ` Junio C Hamano
2006-11-21 20:03 ` Jakub Narebski
2006-11-23 9:25 ` Andy Parkins
2006-11-24 7:49 ` Jakub Narebski
2006-11-23 9:36 ` [PATCH] config option core.showroot to enable showing the diff of the root commit Peter Baumann
2006-11-23 20:52 ` Junio C Hamano
2006-11-23 23:34 ` Peter Baumann [this message]
2006-11-24 0:18 ` Junio C Hamano
2006-11-24 1:30 ` Junio C Hamano
2006-11-24 7:53 ` Peter Baumann
2006-11-24 8:54 ` Junio C Hamano
2006-11-24 9:04 ` Peter Baumann
2006-11-21 18:39 ` git-show --stat on first commit Carl Worth
2006-11-21 19:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=slrnemcc0b.ncc.Peter.B.Baumann@xp.machine.xx \
--to=peter.b.baumann@stud.informatik.uni-erlangen.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).