git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Baumann <Peter.B.Baumann@stud.informatik.uni-erlangen.de>
To: git@vger.kernel.org
Subject: Re: [PATCH] git-reset [--mixed] <tree> [--] <paths>...
Date: Thu, 14 Dec 2006 11:47:18 +0100	[thread overview]
Message-ID: <slrneo2atm.nqa.Peter.B.Baumann@xp.machine.xx> (raw)
In-Reply-To: 7vwt4u96e8.fsf@assigned-by-dhcp.cox.net

On 2006-12-14, Junio C Hamano <junkio@cox.net> wrote:
> Sometimes it is asked on the list how to revert selected path in
> the index from a tree, most often HEAD, without affecting the
> files in the working tree.  A similar operation that also
> affects the working tree files has been available in the form of
> "git checkout <tree> -- <paths>...".
>
> By definition --soft would never affect either the index nor the
> working tree files, and --hard is the way to make the working
> tree files as close to pristine, so this new option is available
> only for the default --mixed case.
>
> Signed-off-by: Junio C Hamano <junkio@cox.net>
> ---
>
>  * I haven't looked at Documentation/git-reset.txt recently.  It
>    most likely needs not just addition to describe this new
>    format, but more a heavier rewrite similar to what we made to
>    git-commit documentation recently.
>
>  git-reset.sh |   68 +++++++++++++++++++++++++++++++++++++++------------------
>  1 files changed, 46 insertions(+), 22 deletions(-)
>
> diff --git a/git-reset.sh b/git-reset.sh
> index 03d2c3b..e95c252 100755
> --- a/git-reset.sh
> +++ b/git-reset.sh
> @@ -1,35 +1,59 @@
>  #!/bin/sh
> -
> -USAGE='[--mixed | --soft | --hard]  [<commit-ish>]'
> +#
> +# Copyright (c) 2005, 2006 Linus Torvalds and Junio C Hamano
> +#
> +USAGE='[--mixed | --soft | --hard]  [<commit-ish>] [ [--] <paths>...]'
>  SUBDIRECTORY_OK=Yes
>  . git-sh-setup
>  
> +update= rev= reset_type=--mixed
> +
> +while case $# in 0) break ;; esac
> +do
> +	case "$1" in
> +	--mixed | --soft | --hard)
> +		reset_type="$1"
> +		;;
> +	--)
> +		break
> +		;;
> +	-*)
> +		usage
> +		;;
> +	*)
> +		rev=$(git-rev-parse --verify "$1") || exit
> +		shift
> +		break
> +		;;
> +	esac
> +	shift
> +done
> +
> +: ${rev=HEAD}
> +rev=$(git-rev-parse --verify $rev^0) || exit
> +
> +# Skip -- in "git reset HEAD -- foo" and "git reset -- foo".
> +case "$1" in --) shift ;; esac
> +
> +# git reset --mixed tree [--] paths... can be used to
> +# load chosen paths from the tree into the index without
> +# affecting the working tree nor HEAD.
> +if test $# != 0
> +then
> +	test "$reset_type" == "--mixed" ||
> +		die "Cannot do partial $reset_type reset."
> +	git ls-tree -r --full-name $rev -- "$@" |
> +	git update-index --add --index-info || exit
> +	git update-index --refresh
> +	exit
> +fi
> +

Why not make

	git-reset --hard <treeish> -- file

aquivalent to

	git-checkout <treeish> -- file

-Peter

PS:	Your patch didn't apply cleanly. And I couldn't find the blobs
	03d2c3b..e95c252 even after pulling (pu, next, master) in my
	git repository

  parent reply	other threads:[~2006-12-14 10:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-14  9:24 [PATCH] git-reset [--mixed] <tree> [--] <paths> Junio C Hamano
2006-12-14 10:02 ` Junio C Hamano
2006-12-14 10:47 ` Peter Baumann [this message]
2006-12-14 20:41   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=slrneo2atm.nqa.Peter.B.Baumann@xp.machine.xx \
    --to=peter.b.baumann@stud.informatik.uni-erlangen.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).