* [PATCH] t7012: Mark missing tests as TODO
@ 2010-04-19 8:14 Michael J Gruber
2010-04-19 8:20 ` Nguyen Thai Ngoc Duy
0 siblings, 1 reply; 2+ messages in thread
From: Michael J Gruber @ 2010-04-19 8:14 UTC (permalink / raw)
To: git; +Cc: Nguyễn Thái Ngọc Duy
Currently, there are 6 tests which are not even written but are
'test_expect_failure message false'.
Do not abuse test_expect_failure as a to do marker, but mark them as
'#TODO' instead.
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
Part of my personal war on test failures... I don't think it is helpful
to have bogus counts for failed tests.
t/t7012-skip-worktree-writing.sh | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/t/t7012-skip-worktree-writing.sh b/t/t7012-skip-worktree-writing.sh
index 8d8b1c0..582d0b5 100755
--- a/t/t7012-skip-worktree-writing.sh
+++ b/t/t7012-skip-worktree-writing.sh
@@ -136,11 +136,11 @@ test_expect_success 'git-clean, dirty case' '
test_cmp expected result
'
-test_expect_failure 'git-apply adds file' false
-test_expect_failure 'git-apply updates file' false
-test_expect_failure 'git-apply removes file' false
-test_expect_failure 'git-mv to skip-worktree' false
-test_expect_failure 'git-mv from skip-worktree' false
-test_expect_failure 'git-checkout' false
+#TODO test_expect_failure 'git-apply adds file' false
+#TODO test_expect_failure 'git-apply updates file' false
+#TODO test_expect_failure 'git-apply removes file' false
+#TODO test_expect_failure 'git-mv to skip-worktree' false
+#TODO test_expect_failure 'git-mv from skip-worktree' false
+#TODO test_expect_failure 'git-checkout' false
test_done
--
1.7.1.rc1.248.gcefbb
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] t7012: Mark missing tests as TODO
2010-04-19 8:14 [PATCH] t7012: Mark missing tests as TODO Michael J Gruber
@ 2010-04-19 8:20 ` Nguyen Thai Ngoc Duy
0 siblings, 0 replies; 2+ messages in thread
From: Nguyen Thai Ngoc Duy @ 2010-04-19 8:20 UTC (permalink / raw)
To: Michael J Gruber; +Cc: git
2010/4/19 Michael J Gruber <git@drmicha.warpmail.net>:
> Currently, there are 6 tests which are not even written but are
> 'test_expect_failure message false'.
> Do not abuse test_expect_failure as a to do marker, but mark them as
> '#TODO' instead.
Ack. Need to write those tests soon.
--
Duy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-19 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-19 8:14 [PATCH] t7012: Mark missing tests as TODO Michael J Gruber
2010-04-19 8:20 ` Nguyen Thai Ngoc Duy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).