From: Catalin Marinas <catalin.marinas@arm.com>
To: "Bahadir Balban" <bahadir.balban@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: stgit: stg mail
Date: Tue, 12 Dec 2006 12:32:15 +0000 [thread overview]
Message-ID: <tnxejr5wb00.fsf@arm.com> (raw)
In-Reply-To: <7ac1e90c0612120412i1297ce05uecbeea1107b8c704@mail.gmail.com> (Bahadir Balban's message of "Tue, 12 Dec 2006 12:12:36 +0000")
"Bahadir Balban" <bahadir.balban@gmail.com> wrote:
> I couldn't succeed in getting stg mail produce an mbox file with a
> Signed-off-by line (using stgit 0.11).
>
> stg mail -m --to=user@mail.com patchname > patchname.diff
>
> works OK. If I add the template with Signed-off-by I get:
>
> stg mail -m --to=user@mail.com -t ~/patch.tmpl patchname > patchname.diff
> stg mail: No "From" address
Your template is wrong since it doesn't have a "From:" line. You would
have to use the templates/patchmail.tmpl as a starting point.
BTW, I prefer to add the "signed-off-by" line in the patch description
rather than automatically (blindly) append it to every e-mailed patch.
--
prev parent reply other threads:[~2006-12-12 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 12:12 stgit: stg mail Bahadir Balban
2006-12-12 12:32 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tnxejr5wb00.fsf@arm.com \
--to=catalin.marinas@arm.com \
--cc=bahadir.balban@gmail.com \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).