stgit: stg mail

stgit: stg mail

[Bahadir Balban]

Hi,

I couldn't succeed in getting stg mail produce an mbox file with a
Signed-off-by line (using stgit 0.11).

stg mail -m --to=user@mail.com patchname > patchname.diff

works OK. If I add the template with Signed-off-by I get:

stg mail -m --to=user@mail.com -t ~/patch.tmpl patchname > patchname.diff
stg mail: No "From" address

Also tried -c with same result.

Config file:
[stgit]
# Default author/committer details
authname: name surname
authemail: user@mail.com
commname:  user@mail.com
commemail: user@mail.com

I guess it expects to find everything in the template? How do you
normally supply signoff field?

Thanks,

Re: stgit: stg mail

[Catalin Marinas]

"Bahadir Balban" <bahadir.balban@gmail.com> wrote:
> I couldn't succeed in getting stg mail produce an mbox file with a
> Signed-off-by line (using stgit 0.11).
>
> stg mail -m --to=user@mail.com patchname > patchname.diff
>
> works OK. If I add the template with Signed-off-by I get:
>
> stg mail -m --to=user@mail.com -t ~/patch.tmpl patchname > patchname.diff
> stg mail: No "From" address

Your template is wrong since it doesn't have a "From:" line. You would
have to use the templates/patchmail.tmpl as a starting point.

BTW, I prefer to add the "signed-off-by" line in the patch description
rather than automatically (blindly) append it to every e-mailed patch.

--