From: Avery Pennarun <apenwarr@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Alexander Gladysh <agladysh@gmail.com>, git@vger.kernel.org
Subject: Re: gitk pays too much attention to file timestamps
Date: Tue, 6 Apr 2010 19:58:41 -0400 [thread overview]
Message-ID: <u2r32541b131004061658r555f21dbgbe011960d9152d3c@mail.gmail.com> (raw)
In-Reply-To: <20100406233601.GA27533@progeny.tock>
On Tue, Apr 6, 2010 at 7:36 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> gitk is something of a passive observer of the index, which is
> actually something I like about it. This keeps it relatively fast
> and can be useful when trying to understand other commands.
>
> I am not sure how other people use gitk, though. Maybe this would
> be worth changing. For a reference point, another command in a
> very similar situation is ‘git diff’: people who want the speedup
> from avoiding refreshing the index with that command use
Isn't it kind of weird, then, that it bothers to check the stat
information at all? I'm not sure why I'd want to know accurately
whether or not my file matches the index, but then have gitk fail to
tell me about *what* doesn't match. If it has to check the stat()
information anyway, isn't it already being slow?
Avery
next prev parent reply other threads:[~2010-04-06 23:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 22:57 gitk pays too much attention to file timestamps Alexander Gladysh
2010-04-06 23:15 ` Markus Heidelberg
2010-04-06 23:36 ` Jonathan Nieder
2010-04-06 23:47 ` Alexander Gladysh
2010-04-07 0:43 ` [PATCH/RFC] gitk: refresh index before checking for local changes Jonathan Nieder
2010-04-07 1:07 ` Alexander Gladysh
2010-04-07 1:16 ` Jonathan Nieder
2010-04-07 2:21 ` A Large Angry SCM
2010-04-07 2:57 ` Jonathan Nieder
2010-04-07 5:47 ` Junio C Hamano
2010-04-07 11:21 ` A Large Angry SCM
2010-04-07 16:48 ` Avery Pennarun
2010-04-07 14:36 ` Jon Seymour
2010-04-06 23:58 ` Avery Pennarun [this message]
2010-04-07 1:01 ` gitk pays too much attention to file timestamps Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u2r32541b131004061658r555f21dbgbe011960d9152d3c@mail.gmail.com \
--to=apenwarr@gmail.com \
--cc=agladysh@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).