From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Daniel Barkalow <barkalow@iabervon.org>,
Tay Ray Chuan <rctay89@gmail.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCH] remote-curl: Add sanity check for url
Date: Wed, 31 Mar 2010 08:13:08 +0530 [thread overview]
Message-ID: <u2tf3271551003301943sf703e66fz4274135efd991430@mail.gmail.com> (raw)
In-Reply-To: <7voci5qspr.fsf@alter.siamese.dyndns.org>
Hi,
> I may be being slow but I do not see the point of this patch.
Agreed, it's not a bug that any end-user would normally bump into. I
bumped into this myself when I assumed that the remote `foo` exists,
and invoked `git-remote-http foo`. Since remote_get() transparently
creates a remote when one does not exist, remote-curl doesn't know if
the remote `foo` ever really exists. Going off to fetch a HTML page
when an expected remote doesn't exist is really ugly, so I thought I'd
prepare this patch. Plus, it doesn't hurt to make sure that the remote
helper conforms to the documentation- useful when a developer is
calling it independently.
-- Ram
prev parent reply other threads:[~2010-03-31 2:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 20:08 [PATCH] remote-curl: Add sanity check for url Ramkumar Ramachandra
2010-03-30 23:45 ` Junio C Hamano
2010-03-31 2:43 ` Ramkumar Ramachandra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u2tf3271551003301943sf703e66fz4274135efd991430@mail.gmail.com \
--to=artagnon@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rctay89@gmail.com \
--cc=spearce@spearce.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).