From: Sverre Rabbelier <srabbelier@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Chris Webb <chris@arachsys.com>
Subject: Re: Tests with broken && chains in pu
Date: Sun, 4 Apr 2010 15:15:27 -0500 [thread overview]
Message-ID: <v2yfabb9a1e1004041315x999376f6m7dd689b529ce33d8@mail.gmail.com> (raw)
In-Reply-To: <201004042208.58939.j6t@kdbg.org>
Heya,
On Sun, Apr 4, 2010 at 15:08, Johannes Sixt <j6t@kdbg.org> wrote:
> two commits in pu currently add tests with broken && chains:
> diff --git a/t/t5800-remote-helpers.sh b/t/t5800-remote-helpers.sh
> index 33f546b..eb31709 100755
> --- a/t/t5800-remote-helpers.sh
> +++ b/t/t5800-remote-helpers.sh
> @@ -9,7 +9,7 @@ test_description='Test remote-helper import and export commands'
>
> test_expect_success 'setup repository' '
> git init --bare server/.git &&
> - git clone server public
> + git clone server public &&
> (cd public &&
> echo content >file &&
> git add file &&
> @@ -18,7 +18,7 @@ test_expect_success 'setup repository' '
> '
>
> test_expect_success 'cloning from local repo' '
> - git clone "testgit::${PWD}/server" localclone
> + git clone "testgit::${PWD}/server" localclone &&
> test_cmp public/file localclone/file
> '
Thanks for noticing, may I ask how you noticed? Do you have a script
or was it manual review?
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2010-04-04 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-04 20:08 Tests with broken && chains in pu Johannes Sixt
2010-04-04 20:15 ` Sverre Rabbelier [this message]
2010-04-04 20:41 ` Johannes Sixt
2010-04-04 20:45 ` Chris Webb
2010-04-04 21:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v2yfabb9a1e1004041315x999376f6m7dd689b529ce33d8@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=chris@arachsys.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).