From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: "Øystein Walle" <oystwa@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH v2] show-branch: use pager
Date: Thu, 13 Jun 2013 11:32:37 +0200 [thread overview]
Message-ID: <vpq1u86pd8q.fsf@anie.imag.fr> (raw)
In-Reply-To: <1371110238-6910-1-git-send-email-oystwa@gmail.com> ("Øystein Walle"'s message of "Thu, 13 Jun 2013 09:57:18 +0200")
Øystein Walle <oystwa@gmail.com> writes:
> This is for consistency with other porcelain commands such as 'log'.
I don't think consistency with other porcelain is a sufficient argument.
Many commands purposely don't use the pager by default because they will
normally have a short output.
Users can already set "pager.show-branch" to get the behavior you
introduce in the patch. The question is more: will users prefer having
the pager by default for this particular command? I don't use
show-branch enough to answer by myself, but probably the answer is yes.
(This is not an objection, just to make sure you have all the elements)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-06-13 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 6:43 [PATCH RFC] show-branch: use pager Øystein Walle
2013-06-13 7:01 ` Jeff King
2013-06-13 7:57 ` [PATCH v2] " Øystein Walle
2013-06-13 9:32 ` Matthieu Moy [this message]
2013-06-13 17:33 ` [PATCH RFC] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq1u86pd8q.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=oystwa@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).