Re: [PATCH 1.8.0] add: make "add -u" update full tree without pathspec

[Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>]

[ Your mailer did something strange with my name and email ]

Junio C Hamano <gitster@pobox.com> writes:

> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> When -u was introduced in dfdac5d (git-add -u: match the index with
>> working tree., 2007-04-20), "add -u" (without pathspec) added
>> everything. Shortly after, 2ed2c22 (git-add -u paths... now works from
>> subdirectory, 2007-08-16) broke it while fixing something related.
>
> As long as the command takes pathspecs, it should never be tree-wide.
> Making it tree-wide when there is no pathspec is even worse.

This is against the common use in Git. As I mentionned in the other
thread, pretty much any git command taking an optional pathspec is
still tree-wide when called without argument. "git add -u" is the
exception.

> If "add -p" does not limit operation to the current directory, probably
> that is the inconsistency bug to be fixed.

Add "git log", "git status", "git commit", "git show", "git diff", and
a few others I've missed to the list of "exceptions" ...

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/